On 08/11/2015 12:08 PM, Lukas Slebodnik wrote:
On (11/08/15 10:47), Pavel Reichl wrote:
> On 08/11/2015 06:45 AM, Lukas Slebodnik wrote:
>> On (10/08/15 19:31), Pavel Reichl wrote:
>> [snip]
>>> From: Pavel Reichl <preichl(a)redhat.com>
>>> Date: Mon, 10 Aug 2015 13:06:37 -0400
>>> Subject: [PATCH 1/2] Remove trailing whitespace
>>>
>>> ---
>>> README | 2 +-
>>> po/ca.po | 2 +-
>> We should not manually edit translation files.
>> Please and exception for these files.
> Thanks, I will do as you propose.
>> [snip]
>> Trivial test should be part of bug fix.
> I'm not sure, I discussed this matter yesterday with Michal and then decided
> for 2 patches. Pusher can always squeeze the patches if he wants.
>> So we will not forget to backport it.
> I really don't think we are going to back port this.
>> It make sense to have a test in separate patch for big features
>> which are tracked by upstream ticket.
>>
> [snip]
>> Please ask Nikolai for review of bash script.
> OK, I will.
>
> Lukas, do you know if there should be a preamble in this file? I noticed
> several other files in git suffixed with .sh that miss preamble as well. So
> I'm not sure.
IANAL
Yes, I thought so but thanks for confirmation anyway.
Updated patch attached.
LS
_______________________________________________
sssd-devel mailing list
sssd-devel(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel