On (29/04/14 18:25), Pavel Reichl wrote:
On Mon, 2014-04-28 at 21:35 +0200, Jakub Hrozek wrote:
> On Mon, Apr 28, 2014 at 01:55:00PM +0200, Pavel Reichl wrote:
> > On Thu, 2014-04-17 at 17:30 +0200, Jakub Hrozek wrote:
> > > On Tue, Apr 15, 2014 at 04:25:50PM +0200, Pavel Reichl wrote:
> > > > Hello,
> > > >
> > > > some more generally useful logging messages are needed for that
> > > > bugzilla.
> > > >
> > > > Patches for both master and 1.11 are attached.
> > > >
> > > > Thanks for review!
> > >
> > > It would be nice to explain in the commit message why you used TRACE_LIBS
> > > for the messages and not i.e OP_FAILURE.
> > >
> > > >
> > > > On Wed, 2014-04-09 at 14:29 +0200, Pavel Reichl wrote:
> > > > > Hello,
> > > > >
> > > > > please see attached patch.
> > > > >
> > > > > This patch was previously written for BZ 1059423. But it now
seems that
> > > > > more detailed logging information is generally useful for issues
that
> > > > > are emerging from this area lately.
> > > > >
> > > > > Pavel Reichl
> > > >
> > > >
> > >
> > > > From e7e4a06098bce4df600370274babe470b0d71c47 Mon Sep 17 00:00:00
2001
> > > > From: Pavel Reichl <reichl.pavel(a)gmail.com>
> > > > Date: Mon, 14 Apr 2014 17:27:23 +0100
> > > > Subject: [PATCH] SDAP: augmented logging when adding new group
> > > >
> > > > Resolves:
> > > >
https://fedorahosted.org/sssd/ticket/2239
>
> ACK for master.
>
> I would like a 1.11 version personally.
> _______________________________________________
> sssd-devel mailing list
> sssd-devel(a)lists.fedorahosted.org
>
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
OK, patches attached.
From 47c158c3dbd63d71a7372823b9d74da252478498 Mon Sep 17 00:00:00
2001
From: Pavel Reichl <preichl(a)redhat.com>
Date: Mon, 14 Apr 2014 17:27:23 +0100
Subject: [PATCH] SYSDB: augmented logging when adding new group
This patch adds some more log messages to functionality of storing groups into
sysdb. As these functions are low level and failures are often handled on
higher levels the commonly chosen level is SSSDBG_TRACE_LIBS.
Resolves:
https://fedorahosted.org/sssd/ticket/2239
---
done:
if (ret) {
@@ -3146,7 +3214,7 @@ int sysdb_cache_auth(struct sysdb_ctx *sysdb,
SYSDB_LAST_FAILED_LOGIN,
time(NULL));
if (ret != EOK) {
- DEBUG(3, ("sysdb_attrs_add_time_t failed\n."));
+ DEBUG(3, ("sysdb_attrs_add_time_t failed.\n"));
goto done;
As you can see this patch was prepared for 1-11 branch with
"old-style" DEBUG macro.
Unfortunatelly, the second patch 0001-SYSDB-augmented-logging-when-adding-new-group.patch
cannot be applied on 1-11 branch
Applying: SYSDB: augmented logging when adding new group
error: patch failed: src/db/sysdb_ops.c:1417
error: src/db/sysdb_ops.c: patch does not apply
error: patch failed: src/providers/ldap/sdap_async_groups.c:246
error: src/providers/ldap/sdap_async_groups.c: patch does not apply
Patch failed at 0001 SYSDB: augmented logging when adding new group
The copy of the patch that failed is found in:
/dev/shm/sssd/.git/rebase-apply/patch
Could you send new version for 1-11 branch?
LS