URL:
https://github.com/SSSD/sssd/pull/870
Title: #870: pam: do not accept empty PIN
pbrezina commented:
"""
Looking at the callers, we are mixing errno with pam return code:
```c
static int prompt_by_config(pam_handle_t *pamh, struct pam_items *pi)
...
case PC_TYPE_SC_PIN:
ret = prompt_sc_pin(pamh, pi);
/* Todo: add extra string option */
break;
default:
ret = EINVAL;
}
```
`EINVAL` should be `PAM_SYSTEM_ERR` or something. Please change that as well.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/870#issuecomment-522965869