Fixing everything else commented before.
On Sat, 2016-03-05 at 15:31 +0100, Jakub Hrozek wrote:
And this is the question. The new code doesn't restore the flags,
this an intentional change? Do you know why we restored the flags
Yes, it is an intentional change as restoring the flags was not needed.
What happens if the function fails is that we are going to close the
socket anyway, so what's the point of restoring flags (which means
removing O_NONBLOCK in the end, somethign we never want to do as all
sockets must be non-blocking in SSSD to avoig hangs.
Fixed patches attacched.
Simo Sorce * Red Hat, Inc * New York