-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 10/14/2010 08:48 PM, Stephen Gallagher wrote:
Patch 0001: Ack.
Patch 0002: Nack
I'd rather you used sysdb_attrs_get_string() to get the SYSDB_NAME in
sdap_add_incomplete_groups().
Done.
strtol() is also not safe here, as gid_t is a uint32_t, which on
32-bit
platforms may require unsigned long.
Done. But IIRC I copied this bit from elsewhere in the code. Do we want
to have a cleanup ticket to use the new sysdb_attrs_get_ulong() facility?
Also, since it would be a very useful thing to have, please add a
function sysdb_attrs_get_ulong() and use that for getting the GID.
This is implemented in new patch 0001.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora -
http://enigmail.mozdev.org/
iEYEARECAAYFAky4ClYACgkQHsardTLnvCXJlgCg2dF8QiH3p3uyhcynDXT5Q++n
nqAAmwcWnW07+N+bneeOgDDO833tGbCx
=xj6y
-----END PGP SIGNATURE-----