On 05/27/2015 10:41 AM, Lukas Slebodnik wrote:
On (27/05/15 10:38), Jakub Hrozek wrote:
> On Wed, May 27, 2015 at 09:52:11AM +0200, Lukas Slebodnik wrote:
>>> +static errno_t
>>> +get_krb_primary(struct map_id_name_to_krb_primary *name_to_primary,
>>> + char *id_prov_name, bool cs, const char **_krb_primary)
>>> + errno_t ret;
>>> + int i = 0;
>>> + while(name_to_primary != NULL &&
>>> + name_to_primary[i].id_name != NULL &&
>> I thought we have a convention to use
>> binary operatort in the begining of
>> line and not at the end.
>> IIRC Stephen sent mail with proposal and we agreed.
>> Sumit uses it quite often.
> Is that a nack or a remark?
It is a start of discussion (remark).
We should make an agreement what do we want to use.
If we don't like Stephen's proposal then
We should agree on something else.
It's really strange to see different convention in different places.
and sometimes difficult (slower?) to read a code.
I honestly don't care much I don't think that this slowers my
understanding of the code, for me other things are way more important.
Lukas do you have subject of the mail? I must have missed that.
I did some fast grepping:
git grep '^[\t ]*\(||\|&&\).*' -- '*.c' | wc -l
git grep '.*\(||\|&&\)[ \t]*$' -- '*.c' | wc -l
It seems to me that logical operator && and || are more commonly used in
the end of lines.
sssd-devel mailing list