On Tue, 23 Feb 2010 11:59:27 -0500 Stephen Gallagher sgallagh@redhat.com wrote:
[PATCH 1/2] Store lastLogin attribute when authenticating online This is needed for the second patch as we rely on lastLogin to decide whether to delete an entry or not.
This one seem to save the last login _only_ when the authentication was made online.
Looks like the wrong way to record the last login. IT seem that the function is misnamed and should be renames to set_last_online_auth(), and a new funciotn names set_last_login() should be created and called when any auth (online or offline) succeeds.
We were already storing the lastLogin for offline auth. It was overlooked for online auth.
Uhmm I see, then the patch is fine. Although we may want to open an RFE to make a better interface to set this information, or at the very least add comments in the code that makes clear why we are doing this here this way.
Simo.