On Wed, Sep 04, 2013 at 12:48:36PM -0400, Stephen Gallagher wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 09/04/2013 12:31 PM, Jakub Hrozek wrote:
> > On Wed, Sep 04, 2013 at 11:15:51AM -0400, Stephen Gallagher wrote:
> > It was discovered that duplicating files in two subpackages is not
> > permitted by Fedora packaging guidelines[1]. This patch moves the
> > PAC responder to a new sssd-common-pac subpackage that both the
> > sssd-ipa and sssd-ad subpackages will require.
> >
> > [1]
> >
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelin...
> >
> >
> >> From b9a5c02af52b042d00c723d70e698deb81fd763c Mon Sep 17 00:00:00
> >> 2001 From: Stephen Gallagher <sgallagh(a)redhat.com> Date: Wed, 4
> >> Sep 2013 11:12:30 -0400 Subject: [PATCH] RPM: Add new subpackage
> >> for PAC responder
> >>
> >> It was discovered that duplicating files in two subpackages is
> >> not permitted by Fedora packaging guidelines[1]. This patch moves
> >> the PAC responder to a new sssd-common-pac subpackage that both
> >> the sssd-ipa and sssd-ad subpackages will require.
> >>
> >> [1]
> >>
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelin...
> >>
> >>
> - ---
> >> contrib/sssd.spec.in | 39
> >> +++++++++++++++++++++++++++++++-------- 1 file changed, 31
> >> insertions(+), 8 deletions(-)
> >>
> >> diff --git a/contrib/sssd.spec.in b/contrib/sssd.spec.in index
> >>
217625a3a0e551f5a99e498773ff71dfea1a32ed..71c400b13e525dfda8ffa22a26e2922420dfe1d9
> >> 100644 --- a/contrib/sssd.spec.in +++ b/contrib/sssd.spec.in @@
> >> -59,6 +59,7 @@ Requires: sssd-common = %{version}-%{release}
> >> Requires: sssd-ldap = %{version}-%{release} Requires: sssd-krb5 =
> >> %{version}-%{release} Requires: sssd-ipa = %{version}-%{release}
> >> +Requires: sssd-common-pac = %{version}-%{release} Requires:
> >> sssd-ad = %{version}-%{release} Requires: sssd-proxy =
> >> %{version}-%{release} Requires: python-sssdconfig =
> >> %{version}-%{release} @@ -243,6 +244,19 @@ Requires:
> >> sssd-krb5-common = %{version}-%{release} Provides the Kerberos
> >> back end that the SSSD can utilize authenticate against a
> >> Kerberos server.
> >>
> >> +# RHEL 5 is too old to support the PAC responder +%if
> >> !0%{?is_rhel5} +%package common-pac +Summary: Common files needed
> >> for supporting PAC processing +Group: Applications/System
> >> +License: GPLv3+ +Conflicts: sssd-ad < %{version}-{release}
> >
> > Shouldn't this new subpackage alco Conflict with sssd-ipa ?
> >
>
> Yeah, but that made me realize that I had this wrong, anyway.
>
> There's no need to Conflict here, because sssd-ad and sssd-ipa have
> strict version dependencies which will pull this in.
>
> It also needs to have "Requires: sssd-common" or else it would be
> possible to install just the 'sssd-common-pac' package (which makes no
> sense).
>
> The attached patch should address this issue.
ACK