On Fri, 2011-05-27 at 23:02 +0200, Jan Zeleny wrote:
Stephen Gallagher <sgallagh(a)redhat.com> wrote:
> On Tue, 2011-05-24 at 11:16 +0200, Jan Zelený wrote:
> > Hi,
> > since Jakub's RFC2307bis patches are already pushed, I've revisited my
AD
> > non- posix group handling patch:
> >
> > 027
> > Added function for retrieving boolean value from sysdb attributes. This
> > function is then utilized in the second patch
>
> Ack
>
> > 028
> > This is the patch I sent before with all modifications which were
> > discussed
>
> Nack.
>
> The changes to the sysdb functions are breaking the unit tests.
>
> As a general kindness to reviewers, please break this patch up into one
> that changes the sysdb group functions and one that implements these
> changes into the LDAP and NSS code. The sysdb change patch should also
> include the necessary unit test fixes.
>
> In sdap_nested_group_process_send() you should 'goto immediate' if you
> fail to mark the group as non-posix.
The new patch set is attached. I did some testing and found some issues with
previous patches, so these are a little different at some places.
Jan
Ack