The first patch solves ticket https://fedorahosted.org/sssd/ticket/1844
The second modifies the test suite to reflect these changes.
The patch moves calculation of UID range for a domain from sdap_idmap
code to sss_idmap. Some changes are:
- Structure sdap_idmap_slice has been removed. The slice number is now
stored in the sss_idmap_range structure.
- The sss_idmap_init() function takes a new parameter: structure
sss_idmap_opts. It holds configurable options (UID bounds, rangesize,
use autorid mode). These values are also accessible outside sss_idmap
(simple getters have been added).
- Options dp_opt_get_int for
SDAP_IDMAP_LOWER/UPPER/AUTORID_COMPAT/RANGESIZE was moved from
sdap_idmap_add_domain to sdap_idmap_init. These values are shared among
subdomains, so there is no need to call it in each sdap_idmap_add_domain
- sss_idmap_calculate_range function is mostly copy of the range
calculation processing in sdap_idmap_add_domain(), but it uses values
stored in sss_idmap_opts and the slice number is taken from the rnge
structure (which is completely created by this function now).
Sumit, could you please review this patch? I think you are most familiar
with the id mapping code.
Also one more question. How should I amend the -version-info value for
libsss_idmap in Makefile.am? Currently it is 0:1:0. Should it be 1:0:0 now?