New tests added to success tests. Please review it.
Thanks,
On Fri, Mar 22, 2013 at 4:48 PM, Stephen Gallagher sgallagh@redhat.comwrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On Fri 22 Mar 2013 04:32:52 AM EDT, Abhishek Singh wrote:
Hi,
I have attached a patch that contains cmocka unittest for io.c . Kindly review it.
This is a good start, but I'd like to see some more comprehensive tests. In the success tests, could you please use fcntl(F_GETFD) to confirm that the file descriptor actually has the correct flags? You can take a look at the sss_open_cloexec() function implementation for inspiration here. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iEYEARECAAYFAlFMPg0ACgkQeiVVYja6o6MHsACfTSehzUmCKYeRVmFeBnOKFUco dJIAnj6CGoKH3psZ97dchvTil5jwEIvE =hEyx -----END PGP SIGNATURE-----