On 07/17/2013 01:48 PM, Jakub Hrozek wrote:
>On Mon, Jun 24, 2013 at 03:02:40PM +0200, Pavel Březina wrote:
>>Unfortunately, the reported did not provide logs from the time of crash. The
>>backtrace only says that it occurred in nsupdate_child_handler() but I'm
>>very confident that the root cause was that the dyndns update reached
>>timeout.
>>
>>The first patch fixes dyndns unit tests to actually reveal the crash.
>>Cooler solution would be to use tevent_loop_wait(), but it contains an issue
>>due to which it is not possible. This issue was reported on Samba mailing
>>list:
https://lists.samba.org/archive/samba-technical/2013-June/093457.html
>>
>
>Can you please add a comment to the code explaining the workaround?
Sure.
>
>>Second patch will fix the crash.
>>
>
>Ack to the second patch.
>
>>What is the difference between child_sig_handler() which uses context
>>suffixed with _old and sss_sigchld_init()?
>
>The new (sss_sigchild_init) code was originally written for the Winbind
>provider that never materialized. Because of the original intent, it
>also has support for "pool" of processes in form of the hash table.
>
>>Would it make sense to update the
>>code to the new sigchld handler?
>
>Yes it would:
>https://fedorahosted.org/sssd/ticket/2020