On (01/09/16 10:30), Jakub Hrozek wrote:
On Thu, Sep 01, 2016 at 09:49:50AM +0200, Petr Cech wrote:
> On 08/31/2016 10:28 AM, Jakub Hrozek wrote:
> > Hi,
> > I documented workflow that we could use for submitting PRs:
> > https://fedorahosted.org/sssd/wiki/GithubWorkflow
> > It's quite similar to what the FreeIPA team uses (although I don't
> > they publicly document it yet).
> > Comments or edits welcome. If there are none, I'll link the page from
> > the Contribute page later.
> I have note to 'Submitting a pull-request'.
> Now we advice to:
> * use github repo,
> * fork it,
> * add it like remote.
> If I understand correctly there is no reason
> for contributors to clone original
> fedorahosted repo. Is it right?
Yeah, you can clone github/sssd/sssd.git directly. Only those who want
to push need to clone the fedorahosted repo.
(Cloning fedorahosted would also make sure you always get the canonical
sources i ncase the fedorahosted->github mirroring breaks or in case we
move away from github in the future..)
> We should rewrite Contribute wiki page in this manner.
Yes, I'll do that later today I guess.
I do not agree.
github workflow wiki says: "Github pull requests are the preferred way"
It does not say it is a only way how to contribute
So fedorahosted repo is a primary repo therefore it should be
listed in the "Contribute wiki" page.
BTW editing .git/config is error prone; especially if name of remote repo
is not a "github"
url = https://github.com/SSSD/sssd.git
fetch = +refs/heads/*:refs/remotes/github/*
fetch = +refs/pull/*/head:refs/remotes/github/pull/*
It would be better to use "git config"
git config --add remote.$GITHUB_REMOTE.fetch \