On 08/08/2013 02:02 AM, Simo Sorce wrote:
On Thu, 2013-08-08 at 00:15 +0200, Pavel Březina wrote:
> On 08/07/2013 03:40 PM, Ondrej Kos wrote:
>> While working on another issue, I noticed a warning in recently added
>> code (commit fb945a2c). On F18 the build works fine, but not on F19.
>> This is caused by the change of cyrus-sasl API, they changed the
>> *sasl_callback_t* callback member from
>> int (*proc)();
>> int (*proc)(void);
>> Attached patch adds typedef for propper cast and fixes the issue.
> minor nack. Please append _t to the name to imply it's a #typedef and
> prefix it with sss_ to avoid possible conflict with future sasl API.
Actually the _t suffix is now reserved and shouldn't be used.
I agree with the prefix.
I would call it sss_sasl_gen_cb_fn, so make it clear it is a function.
Thanks for the notes, new patch is attached.
Associate Software Engineer
Identity Management - SSSD
Red Hat Czech