-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 11/17/2009 04:16 PM, Jakub Hrozek wrote:
On 11/17/2009 12:16 PM, Jakub Hrozek wrote:
> On 11/17/2009 01:06 AM, Jakub Hrozek wrote:
>> [PATCH 1/2] Add Simo's ipachangeconf
>> This patch adds the ipachangeconf class from FreeIPA and packages it in
>> makefile and with python setuptools
>> [PATCH 2/2] Change the upgrade script to use ipachangeconf
>> With this patch, the upgrade script we use for changing the config files
>> is able to keep ordering and comments.
>> Fixes: #249
> Self-NACK to patch 2 & new patches attached.
As discussed on IRC, I'm resending the same two patches, just formatted
with git format-patch -M to detect renamed upgrade script
I have merged the patches for the upgrade script with the SSSDConfig
patches into this thread. I think it makes sense to review them together:
[PATCH 1/6] Add Simo's ipachangeconf
This patch adds the ipahangeconf class from FreeIPA and packages it in
makefile and with python setuptools
[PATCH 2/6] SSSDChangeConf - a wrapper around ipachangeconf
Provides a convenient wrapper around ipachangeconf that is closer
API-wise to ConfigParser
[PATCH 3/6] Change the upgrade script to use ipachangeconf
With this patch, the upgrade script we use for changing the config files
is able to keep ordering and comments.
Fixes: #249
[PATCH 4/6] Convert SSSDConfig API to ipachangeconf
With this patch, SSSDConfigAPI is able to keep comments and ordering of
sections.
Fixes: #226
[PATCH 5/6] SSSDConfigAPI fixes
* splitlist is a function
* shared SSSDConfigObject to reduce code duplication
* added missing exception class
* fixed some typos
* remove extra 'pass' in unittests
* use assertRaises in unittests
[PATCH 6/6] upgrade_config fixes for SSSD 0.6 and later
Incorporates changes we made to v2 after 0.6, or that were missed by the
original upgrade script:
* removes magic_private_groups option
* removes libPath option
* changes provider=files to provider=proxy proxy_lib_name=files
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora -
http://enigmail.mozdev.org/
iEYEARECAAYFAksFoFEACgkQHsardTLnvCX0SgCgjJZQ9gQTloz60K8S2mcWvsQe
UK4AoImjQE2zJWNByj+2iHqoK6KhbbYg
=3wjX
-----END PGP SIGNATURE-----