Re: [SSSD] [PATCH] Better cleanup task handling

On Tue, 23 Feb 2010 13:50:42 +0100 Jakub Hrozek jhrozek@redhat.com wrote:

[PATCH 1/2] Store lastLogin attribute when authenticating online This is needed for the second patch as we rely on lastLogin to decide whether to delete an entry or not.

This one seem to save the last login _only_ when the authentication was made online.

Looks like the wrong way to record the last login. IT seem that the function is misnamed and should be renames to set_last_online_auth(), and a new funciotn names set_last_login() should be created and called when any auth (online or offline) succeeds.

Simo.