On 10/23/2015 12:57 PM, Jakub Hrozek wrote:
Thank you, I think your approach is correct. Your test essentially
tests
that testuser2 was on the server but was removed, so only testuser1 is
returned.
It's correct, but because the interface is able to return more users, I
would prefer if we tested that as well.
I have one more minor remark inline, but in general, please go
ahead and add back the other tests..
Hello Jakub and everyone!
The first patch set is attached.
The removed tests were:
* users_by_filter_valid
* users_by_filter_multiple_domains_valid
* groups_by_filter_valid
* groups_by_filter_multiple_domains_valid
This patch set covers users_by_filter_valid by two new tests:
* user_by_recent_filter_valid
* users_by_recent_filter_valid
The first of them tests the recent filter. The seconds tests interface
ability to return more users.
Regards,
Petr