On Wed, Dec 08, 2010 at 02:51:06PM -0500, Stephen Gallagher wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 12/07/2010 05:54 AM, Sumit Bose wrote:
> Hi,
>
> due to recent changes in the IPA project the following two patches will
> remove the evaluation based on the ipa_timerules from the IPA access
> provider of SSSD. If you are evaluating the IPA alpha releases with
> respect to time ranges in HBAC rules please note that this patch will
> change the behaviour.
>
> The first patch removes all related calls from the IPA provider while
> the second removes the implementation of the checks and the
> corresponding tests.
>
> This patch should fix trac ticket #698.
Nack. You forgot to remove the IPA_ACCESS_TIME define.
I've attached a patch we can squash in. Please review it, and if it's
acked I'll squash it in and push the revised patch.
ACK
bye,
Sumit
- --
Stephen Gallagher
RHCE 804006346421761
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora -
http://enigmail.mozdev.org/
iEYEARECAAYFAkz/4aoACgkQeiVVYja6o6OodwCgngKIp7ukOu9AM+tlv8EjgQ3I
N+gAoKq7fqYCeQiUzDZklZKdTgpeNiR2
=5M+8
-----END PGP SIGNATURE-----
From
c527e06f1528c0585bc962f8149350f4cc8efec6 Mon Sep 17 00:00:00 2001
From: Stephen Gallagher <sgallagh(a)redhat.com>
Date: Wed, 8 Dec 2010 14:49:09 -0500
Subject: [PATCH] Remove IPA_ACCESS_TIME define
---
src/providers/ipa/ipa_access.c | 24 +++++++++++-------------
1 files changed, 11 insertions(+), 13 deletions(-)
diff --git a/src/providers/ipa/ipa_access.c b/src/providers/ipa/ipa_access.c
index 3b188f0979866b2cd5afc31668657495be0c34ad..130008d2f7afd390e33ba9063d01cdfa5d97bc88
100644
--- a/src/providers/ipa/ipa_access.c
+++ b/src/providers/ipa/ipa_access.c
@@ -41,7 +41,6 @@
#define IPA_SOURCE_HOST "sourceHost"
#define IPA_SOURCE_HOST_CATEGORY "sourceHostCategory"
#define IPA_EXTERNAL_HOST "externalHost"
-#define IPA_ACCESS_TIME "accessTime"
#define IPA_UNIQUE_ID "ipauniqueid"
#define IPA_ENABLED_FLAG "ipaenabledflag"
#define IPA_MEMBER_HOST "memberHost"
@@ -1067,7 +1066,7 @@ static struct tevent_req *hbac_get_rules_send(TALLOC_CTX *memctx,
goto fail;
}
- state->hbac_attrs = talloc_array(state, const char *, 18);
+ state->hbac_attrs = talloc_array(state, const char *, 17);
if (state->hbac_attrs == NULL) {
DEBUG(1, ("Failed to allocate HBAC attribute list.\n"));
ret = ENOMEM;
@@ -1080,17 +1079,16 @@ static struct tevent_req *hbac_get_rules_send(TALLOC_CTX
*memctx,
state->hbac_attrs[4] = IPA_SOURCE_HOST;
state->hbac_attrs[5] = IPA_SOURCE_HOST_CATEGORY;
state->hbac_attrs[6] = IPA_EXTERNAL_HOST;
- state->hbac_attrs[7] = IPA_ACCESS_TIME;
- state->hbac_attrs[8] = IPA_UNIQUE_ID;
- state->hbac_attrs[9] = IPA_ENABLED_FLAG;
- state->hbac_attrs[10] = IPA_CN;
- state->hbac_attrs[11] = OBJECTCLASS;
- state->hbac_attrs[12] = IPA_MEMBER_HOST;
- state->hbac_attrs[13] = IPA_HOST_CATEGORY;
- state->hbac_attrs[14] = IPA_MEMBER_SERVICE;
- state->hbac_attrs[15] = IPA_SERVICE_CATEGORY;
- state->hbac_attrs[16] = SYSDB_ORIG_DN;
- state->hbac_attrs[17] = NULL;
+ state->hbac_attrs[7] = IPA_UNIQUE_ID;
+ state->hbac_attrs[8] = IPA_ENABLED_FLAG;
+ state->hbac_attrs[9] = IPA_CN;
+ state->hbac_attrs[10] = OBJECTCLASS;
+ state->hbac_attrs[11] = IPA_MEMBER_HOST;
+ state->hbac_attrs[12] = IPA_HOST_CATEGORY;
+ state->hbac_attrs[13] = IPA_MEMBER_SERVICE;
+ state->hbac_attrs[14] = IPA_SERVICE_CATEGORY;
+ state->hbac_attrs[15] = SYSDB_ORIG_DN;
+ state->hbac_attrs[16] = NULL;
ret = sss_filter_sanitize(state, host_dn, &host_dn_clean);
if (ret != EOK) {
--
1.7.3.2
_______________________________________________
sssd-devel mailing list
sssd-devel(a)lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/sssd-devel