On (28/06/16 17:22), Jakub Hrozek wrote:
On Tue, Jun 28, 2016 at 12:48:04PM +0200, Lukas Slebodnik wrote:
> On (20/06/16 08:49), Simo Sorce wrote:
> >On Mon, 2016-06-20 at 11:04 +0200, Lukas Slebodnik wrote:
> >> On (19/06/16 15:27), Simo Sorce wrote:
> >> >As the commit message says, nothing more.
> >> >Isn't it right to wait for 6 seconds as the timeout says ?
> >> >Can you add debug to see what errno is returned (if any) ?
> >> >Or does the code never trigger and only the timeout kick in ?
> >> >
> >> Yes, only the timeout kick in
> >> It might be caused by using DROP instead of REJECT in firewall.
> >> But users use DROP very often as well. But I'm not sure.
> >
> >If you had drop then I would expect you always to have to wait 6
> >seconds, the only case I can see happening here is that on a RST the
> >epoll actually returns a readable event instead of a writable one.
> >
> >> >We can revert that change in tevent flags if they cause a regression,
> >> >but I want a comment in the code that the connect() man page is
> >> >misleading if that's the case.
> >> >
> >> I added comment; similar as in commit message.
> >
> >Both commits look good to me.
> >
> Are there any other comments form other developers?
Please push them (I didn't do any tests, but I trust you did).
master:
* bdadcaf271818e88e56e86c2bd90663a08fd9721
* 3108e0cce47ee168b86ac0de1deccee7e7f09119
LS