From sssd-github-notification at fedorahosted.org Mon Oct 3 13:29:21 2016 Content-Type: multipart/mixed; boundary="===============0044153042638112817==" MIME-Version: 1.0 From: fidencio To: sssd-devel at lists.fedorahosted.org Subject: [SSSD] [sssd PR#33][comment] SECRETS: Some small misc fixes + fixing #3168 Date: Mon, 03 Oct 2016 15:29:05 +0200 Message-ID: In-Reply-To: gh-SSSD/sssd-33@sssd-github-notification.fedorahosted.org --===============0044153042638112817== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable URL: https://github.com/SSSD/sssd/pull/33 Title: #33: SECRETS: Some small misc fixes + fixing #3168 jhrozek commented: """ On Fri, Sep 30, 2016 at 07:55:00AM -0700, fidencio wrote: > And here is the diff between the last series and the new one that's arriv= ing in a few ... > = > src/config/SSSDConfig/__init__.py.in | 1 + > src/config/etc/sssd.api.conf | 1 + > src/responder/secrets/local.c | 2 +- > 3 files changed, 3 insertions(+), 1 deletion(-) > = > diff --git a/src/config/SSSDConfig/__init__.py.in b/src/config/SSSDConfig= /__init__.py.in > index 15b9cd1..74c2ca5 100644 > --- a/src/config/SSSDConfig/__init__.py.in > +++ b/src/config/SSSDConfig/__init__.py.in > @@ -120,6 +120,7 @@ option_strings =3D { > = > # [secrets] > 'provider': _('The provider where the secrets will be stored in'), > + 'containers_nest_level': _('The maximum allowed number of nested con= tainers'), > # secrets - proxy > 'proxy_url': _('The URL Custodia server is listening on'), > 'auth_type': _('The method to use when authenticating to a Custodia = server'), > diff --git a/src/config/etc/sssd.api.conf b/src/config/etc/sssd.api.conf > index f94c8d1..a7757dc 100644 > --- a/src/config/etc/sssd.api.conf > +++ b/src/config/etc/sssd.api.conf > @@ -97,6 +97,7 @@ user_attributes =3D str, None, false > [secrets] > # Secrets service > provider =3D str, None, false > +containers_nest_level =3D int, None, false > # Secrets service - proxy > proxy_url =3D str, None, false > auth_type =3D str, None, false > diff --git a/src/responder/secrets/local.c b/src/responder/secrets/local.c > index 06260f3..ec84537 100644 > --- a/src/responder/secrets/local.c > +++ b/src/responder/secrets/local.c > @@ -334,7 +334,7 @@ done: > } > = > static int local_db_check_containers_nest_level(struct local_context *lc= tx, > - struct ldb_dn *leaf_dn) > + struct ldb_dn *leaf_dn) > { > int nest_level; > = > = Thank you, all the patches look good to me now, I did some basic manual testing, I tested the particular case which gives me a 406 when I reach the nesting limit: curl -H "Content-Type: application/json" --unix-socket /var/run/secrets.soc= ket -XPOST http://localhost/secrets/con1/con2/con3/con4/con5/ 406 Not Acceptable

Not Acceptable

The request cannot be accepted.

CI also passed: http://sssd-ci.duckdns.org/logs/job/54/50/summary.html so ACK to all patches. """ See the full comment at https://github.com/SSSD/sssd/pull/33#issuecomment-2= 51105537 --===============0044153042638112817==--