URL: https://github.com/SSSD/sssd/pull/5788
Author: sumit-bose
Title: #5788: debug: suppress backtrace if GetAccountDomain() is not supported
Action: opened
PR body:
"""
The return code ERR_GET_ACCT_DOM_NOT_SUPPORTED is an expected return code
if the backend does not support the GetAccountDomain() request and there is
no need to trigger a backtrace in the logs in this case.
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5788/head:pr5788
git checkout pr5788
URL: https://github.com/SSSD/sssd/pull/5766
Title: #5766: Sources cleanup - part 3.
alexey-tikhonov commented:
"""
> If you encoutner malformed entry, delete it. But klist should return empty ccache, not an error.
This way user will not have any feedback in case of db corruption for any reason (not only because of old format). But probably this is ok.
"""
See the full comment at https://github.com/SSSD/sssd/pull/5766#issuecomment-925764323
URL: https://github.com/SSSD/sssd/pull/5766
Title: #5766: Sources cleanup - part 3.
alexey-tikhonov commented:
"""
> After upgrade from json-ed ccache I got:
> ```
> [pbrezina /dev/shm/sssd]$ klist
> klist: Internal credentials cache error
> ```
> IMHO it is something to fix if the fix is trivial
What do you mean by "to fix"? Since code that works with old format is removed, there is no way to use old ccache.
Do you mean to "skip" (ignore) it somehow? This would require to keep old attr values in the code...
"""
See the full comment at https://github.com/SSSD/sssd/pull/5766#issuecomment-924372997
URL: https://github.com/SSSD/sssd/pull/5766
Title: #5766: Sources cleanup - part 3.
pbrezina commented:
"""
After upgrade from json-ed ccache I got:
```
[pbrezina /dev/shm/sssd]$ klist
klist: Internal credentials cache error
```
IMHO it is something to fix if the fix is trivial, but I was able to kinit successfully so it is fine if the fix would be difficult. Otherwise the changes look good to me.
I didn't see this debian failure on other pull requests so I would like to wait until we understand what is happening there.
"""
See the full comment at https://github.com/SSSD/sssd/pull/5766#issuecomment-922859989
URL: https://github.com/SSSD/sssd/pull/5766
Title: #5766: Sources cleanup - part 3.
pbrezina commented:
"""
After upgrade from json-ed ccache I got:
```
[pbrezina /dev/shm/sssd]$ klist
klist: Internal credentials cache error
```
IMHO it is something to fix if the fix is trivial, but I was able to kinit successfully so it is fine if the fix would be difficult.
I didn't see this debian failure on other pull requests so I would like to wait until we understand what is happening there.
"""
See the full comment at https://github.com/SSSD/sssd/pull/5766#issuecomment-922859989