URL: https://github.com/SSSD/sssd/pull/5203
Author: travier
Title: #5203: sss_cache: Do nothing if SYSTEMD_OFFLINE=1
Action: edited
Changed field: title
Original value:
"""
sss_cache: Do nothing if either /var is RO or SYSTEMD_OFFLINE=1
"""
URL: https://github.com/SSSD/sssd/pull/5226
Title: #5226: python/pysss_nss_idmap: check return from functions
ikerexxe commented:
"""
> I think you just spotted yet another one place that needs fixing: `TYPE_READY` calls `PyModule_AddObject()` and doesn't check a result.
>
> Moreover, taking into account where this macro (`TYPE_READY`) is used, `Py_XDECREF` should be called there as well, IMO.
Agreed. Take a look to the latest update, which contains all the aforementioned errors fixed.
"""
See the full comment at https://github.com/SSSD/sssd/pull/5226#issuecomment-689423505
URL: https://github.com/SSSD/sssd/pull/5226
Title: #5226: python/pysss_nss_idmap: check return from functions
alexey-tikhonov commented:
"""
I think you just spotted yet another one place that needs fixing: `TYPE_READY` calls `PyModule_AddObject()` and doesn't check a result.
Moreover, taking into account where this macro (`TYPE_READY`) is used, `Py_XDECREF` should be called there as well, IMO.
"""
See the full comment at https://github.com/SSSD/sssd/pull/5226#issuecomment-688929798
URL: https://github.com/SSSD/sssd/pull/5226
Title: #5226: python/pysss_nss_idmap: check return from functions
ikerexxe commented:
"""
> Thanks for the update. Please see comment inline.
Yes, it makes sense. I'll change it.
>
> Btw, wouldn't it make sense to include `Py_DECREF(module);` (actually better `Py_XDECREF`) into `MODINITERROR`?
It makes sense to include `Py_XDECREF(module)` in another macro called `FREEMOD_AND_RETURN`(?) and call it from the changes I've made. I wouldn't like messing with `MODINITERROR` as it's already called from other places where it doesn't make to decrease module. An example: https://github.com/SSSD/sssd/blob/fbc7082149ccc6ee4fe077480a5d692a86e75c7...
What do you think?
"""
See the full comment at https://github.com/SSSD/sssd/pull/5226#issuecomment-688916091