[sssd PR#1009][opened] Use ndr_pull_steal_switch_value for modern samba versions
by noelpower
URL: https://github.com/SSSD/sssd/pull/1009
Author: noelpower
Title: #1009: Use ndr_pull_steal_switch_value for modern samba versions
Action: opened
PR body:
"""
commit bc56b10aea999284458dcc293b54cf65288e325d attempted to
fix the build error resulting from removal of 'ndr_pull_get_switch'
However this just basically leaves the old code in place, the
reason for the change in the samba code was to address a possible
NDR crash from possible illegal large array allocations, please
see https://bugzilla.samba.org/show_bug.cgi?id=13876
This change uses the new replacement method
'ndr_pull_steal_switch_value' if available and otherwise puts
back the old method (which better describes what the code is doing)
Signed-off-by: Noel Power <noel.power(a)suse.com>
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/1009/head:pr1009
git checkout pr1009
4 years
Heads up. Moving to github on April 8
by Pavel Březina
SSSD repository is currently spread over multiple places. We use Pagure
[1][2] to manage upstream issues and documentation and Github [3] as our
main development platform.
We chose to move only to a single platform to reduce number of tools we
use and to have everything at one place. We decided to move from Pagure
to Github.
There are several steps that needs to be done in order to achieve this
change but the most significant for our users and contributors is: We
will no longer accept new issues and pull request in Pagure and we will
kindly ask you to use Github instead.
I will disable issues and pull request on Pagure and enable issues on
Github on Wednesday, April 8.
Thank you.
Best regards,
Pavel.
[1] https://pagure.io/SSSD/sssd
[2] https://pagure.io/SSSD/docs
[3] https://github.com/SSSD/sssd
4 years
[sssd PR#1000][comment] Support NSS networks database lookups
by pbrezina
URL: https://github.com/SSSD/sssd/pull/1000
Title: #1000: Support NSS networks database lookups
pbrezina commented:
"""
Thank you. I see these warnings:
```
CC src/util/libsss_util_la-domain_info_utils.lo
/home/pbrezina/workspace/sssd/src/db/sysdb_ipnetworks.c: In function ‘sysdb_getipnetworkbyname’:
/home/pbrezina/workspace/sssd/src/db/sysdb_ipnetworks.c:85:35: error: passing argument 5 of ‘sysdb_search_ipnetworks’ from incompatible pointer type [-Werror=incompatible-pointer-types]
85 | &res->count, &res->msgs);
| ^~~~~~~~~~~
| |
| unsigned int *
In file included from /home/pbrezina/workspace/sssd/src/db/sysdb_ipnetworks.c:27:
/home/pbrezina/workspace/sssd/src/db/sysdb_ipnetworks.h:81:41: note: expected ‘size_t *’ {aka ‘long unsigned int *’} but argument is of type ‘unsigned int *’
81 | size_t *msgs_count,
| ~~~~~~~~^~~~~~~~~~
/home/pbrezina/workspace/sssd/src/db/sysdb_ipnetworks.c: In function ‘sysdb_getipnetworkbyaddr’:
/home/pbrezina/workspace/sssd/src/db/sysdb_ipnetworks.c:152:35: error: passing argument 5 of ‘sysdb_search_ipnetworks’ from incompatible pointer type [-Werror=incompatible-pointer-types]
152 | &res->count, &res->msgs);
| ^~~~~~~~~~~
| |
| unsigned int *
In file included from /home/pbrezina/workspace/sssd/src/db/sysdb_ipnetworks.c:27:
/home/pbrezina/workspace/sssd/src/db/sysdb_ipnetworks.h:81:41: note: expected ‘size_t *’ {aka ‘long unsigned int *’} but argument is of type ‘unsigned int *’
81 | size_t *msgs_count,
| ~~~~~~~~^~~~~~~~~~
/home/pbrezina/workspace/sssd/src/db/sysdb_ipnetworks.c: In function ‘sysdb_enumnetent’:
/home/pbrezina/workspace/sssd/src/db/sysdb_ipnetworks.c:853:35: error: passing argument 5 of ‘sysdb_search_ipnetworks’ from incompatible pointer type [-Werror=incompatible-pointer-types]
853 | &res->count, &res->msgs);
| ^~~~~~~~~~~
| |
| unsigned int *
/home/pbrezina/workspace/sssd/src/db/sysdb_ipnetworks.c:643:41: note: expected ‘size_t *’ {aka ‘long unsigned int *’} but argument is of type ‘unsigned int *’
643 | size_t *msgs_count,
| ~~~~~~~~^~~~~~~~~~
cc1: all warnings being treated as errors
```
```
$ echo $CFLAGS
-m64 -mtune=generic -fstack-protector-all -Wall -Wextra -Wno-sign-compare -Wshadow -Wunused-variable -Wno-unused-parameter -Wno-error=cpp -O0 -ggdb3 -Werror -Wp,-U_FORTIFY_SOURCE
$ rpm -q gcc
gcc-9.2.1-1.fc31.x86_64
```
"""
See the full comment at https://github.com/SSSD/sssd/pull/1000#issuecomment-607160585
4 years