[sssd PR#867][opened] ci: use python2 version of pytest
by pbrezina
URL: https://github.com/SSSD/sssd/pull/867
Author: pbrezina
Title: #867: ci: use python2 version of pytest
Action: opened
PR body:
"""
Fedora 31 changed symlink of /usr/bin/py.test from pytest2 to pytest3.
We need to run the python2 version in order to run our tests with python2.
We might want to switch to Python3 in the future, but this is a quick fix
for current situation when we cannot test against rawhide.
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/867/head:pr867
git checkout pr867
4 years, 1 month
[sssd PR#820][opened] ad: delete domains disabled through ad_enabled_domains from cache
by pbrezina
URL: https://github.com/SSSD/sssd/pull/820
Author: pbrezina
Title: #820: ad: delete domains disabled through ad_enabled_domains from cache
Action: opened
PR body:
"""
Steps to reproduce:
1. Have at least one subdomain in ad domain (e.g. child.ad.vm is subdomain of ad.vm).
2. Enable all domains, set ad_enabled_domains =
[ad.vm]
...
ad_enabled_domains =
3. Look up 'administrator(a)child.ad.vm'
$ id administrator(a)child.ad.vm
uid=1678800500(administrator(a)child.ad.vm) ...
4. Disable the subdomain by setting 'ad_enabled_domains = ad.vm'
5. Restart sssd without clearing the cache
6. Request for *(a)child.ad.vm will go to data provider and try to lookup the user in child.ad.vm domain which will yield 'domain not found'. However if the user is cached it will return the user.
$ id administrator(a)child.ad.vm
uid=1678800500(administrator(a)child.ad.vm) ...
Subdomains that are not root domains are removed from cache. Root domains are
disabled in sysdb with new `enabled` attribute.
Resolves:
https://pagure.io/SSSD/sssd/issue/4009
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/820/head:pr820
git checkout pr820
4 years, 1 month
sss_nfs_[ug]id_to_name not properly respecting the libnfsidmap interface
by Richard Sharpe
Hi folks,
In the current code downloaded from github I see the following function:
src/sss_client/nfs/sss_nfs_client.c:sss_nfs_uid_to_name:
static int sss_nfs_uid_to_name(uid_t uid, char *domain, char *name, size_t len)
{
int rc;
if (name == NULL) {
IDMAP_LOG(0, ("%s: name is null", __func__));
return -EINVAL;
}
rc = get_user_from_mc(name, len, uid);
if (rc != 0) {
rc = id_to_name(name, len, uid, SSS_NSS_GETPWUID);
}
log_actual_rc(__func__, rc);
rc = normalise_rc(rc);
return -rc;
}
The code does nothing with the domain parameter, however, the
interface requirement is that if an unqualified name is to be
returned, perhaps from /etc/passwd, if domain is non null, it should
be appended to the name to be returned preceded by an '@'.
Eg, administrators@localhost.
The same goes for sss_nfs_gid_to_name.
See, for example, nfs-utils:support/nfsidmap/nss.c:nss_uid_to_name
which calls write_name to handle appending the local domain name
passed in if one is not present.
Have I missed something here?
--
Regards,
Richard Sharpe
(何以解憂?唯有杜康。--曹操)(传说杜康是酒的发明者)
4 years, 1 month