sssd-devel November 2019

sssd-devel@lists.fedorahosted.org

2 participants
79 discussions

[sssd PR#945][comment] p11_child: add 'soft_ocsp' and 'soft_crl options
by alexey-tikhonov 27 Nov '19

27 Nov '19

URL: https://github.com/SSSD/sssd/pull/945 Title: #945: p11_child: add 'soft_ocsp' and 'soft_crl options alexey-tikhonov commented: """ Man page: ``` If a Certificate Revocation List (CRL) is expired ignored the CRL checks ``` -- should it say "ignores" or "ignore" instead of "ignored"? """ See the full comment at https://github.com/SSSD/sssd/pull/945#issuecomment-559219420

1 0

[sssd PR#945][comment] p11_child: add 'soft_ocsp' and 'soft_crl options
by alexey-tikhonov 27 Nov '19

27 Nov '19

URL: https://github.com/SSSD/sssd/pull/945 Title: #945: p11_child: add 'soft_ocsp' and 'soft_crl options alexey-tikhonov commented: """ Coverity complains: ``` Error: CLANG_WARNING: sssd-2.2.3/src/p11_child/p11_child_openssl.c:779:17: warning: Value stored to 'ret' is never read # ret = EINVAL; # ^ ~~~~~~ sssd-2.2.3/src/p11_child/p11_child_openssl.c:779:17: note: Value stored to 'ret' is never read # ret = EINVAL; # ^ ~~~~~~ # 777| ret, # 778| X509_verify_cert_error_string(ret)); # 779|-> ret = EINVAL; # 780| goto done; # 781| } Error: CLANG_WARNING: sssd-2.2.3/src/p11_child/p11_child_openssl.c:793:13: warning: Value stored to 'ret' is never read # ret = EINVAL; # ^ ~~~~~~ sssd-2.2.3/src/p11_child/p11_child_openssl.c:793:13: note: Value stored to 'ret' is never read # ret = EINVAL; # ^ ~~~~~~ # 791| DEBUG(SSSDBG_OP_FAILURE, "X509_verify_cert failed [%d][%s].\n", # 792| ret, X509_verify_cert_error_string(ret)); # 793|-> ret = EINVAL; # 794| goto done; # 795| } ``` """ See the full comment at https://github.com/SSSD/sssd/pull/945#issuecomment-559205920

1 0

[sssd PR#945][+Changes requested] p11_child: add 'soft_ocsp' and 'soft_crl options
by alexey-tikhonov 27 Nov '19

27 Nov '19

URL: https://github.com/SSSD/sssd/pull/945 Title: #945: p11_child: add 'soft_ocsp' and 'soft_crl options Label: +Changes requested

1 0

[sssd PR#945][comment] p11_child: add 'soft_ocsp' and 'soft_crl options
by alexey-tikhonov 27 Nov '19

27 Nov '19

URL: https://github.com/SSSD/sssd/pull/945 Title: #945: p11_child: add 'soft_ocsp' and 'soft_crl options alexey-tikhonov commented: """ ``` Error: CLANG_WARNING: sssd-2.2.3/src/p11_child/p11_child_openssl.c:779:17: warning: Value stored to 'ret' is never read # ret = EINVAL; # ^ ~~~~~~ sssd-2.2.3/src/p11_child/p11_child_openssl.c:779:17: note: Value stored to 'ret' is never read # ret = EINVAL; # ^ ~~~~~~ # 777| ret, # 778| X509_verify_cert_error_string(ret)); # 779|-> ret = EINVAL; # 780| goto done; # 781| } Error: CLANG_WARNING: sssd-2.2.3/src/p11_child/p11_child_openssl.c:793:13: warning: Value stored to 'ret' is never read # ret = EINVAL; # ^ ~~~~~~ sssd-2.2.3/src/p11_child/p11_child_openssl.c:793:13: note: Value stored to 'ret' is never read # ret = EINVAL; # ^ ~~~~~~ # 791| DEBUG(SSSDBG_OP_FAILURE, "X509_verify_cert failed [%d][%s].\n", # 792| ret, X509_verify_cert_error_string(ret)); # 793|-> ret = EINVAL; # 794| goto done; # 795| } ``` """ See the full comment at https://github.com/SSSD/sssd/pull/945#issuecomment-559205920

1 0

[sssd PR#945][synchronized] p11_child: add 'soft_ocsp' and 'soft_crl options
by sumit-bose 27 Nov '19

27 Nov '19

URL: https://github.com/SSSD/sssd/pull/945 Author: sumit-bose Title: #945: p11_child: add 'soft_ocsp' and 'soft_crl options Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/945/head:pr945 git checkout pr945

1 0

[sssd PR#924][opened] [WiP] Amend util/server.c:become_daemon()
by alexey-tikhonov 27 Nov '19

27 Nov '19

URL: https://github.com/SSSD/sssd/pull/924 Author: alexey-tikhonov Title: #924: [WiP] Amend util/server.c:become_daemon() Action: opened PR body: """ Fixed a number of issues in/with `become_daemon()` function. Among others fixed this covscan issue: ``` Error: CLANG_WARNING: sssd-2.2.3/src/util/server.c:98:25: warning: Value stored to 'ret' is never read # ret = 1; # ^ ~ sssd-2.2.3/src/util/server.c:98:25: note: Value stored to 'ret' is never read # ret = 1; # ^ ~ # 96| /* Forcibly kill this child */ # 97| kill(pid, SIGKILL); # 98|-> ret = 1; # 99| } # 100| } ``` This PR is marked as [WiP] as it has to be rebased on the top of PR #921. """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/924/head:pr924 git checkout pr924

3 17

[sssd PR#932][opened] SBUS: defer deallocation of sbus_watch_ctx
by alexey-tikhonov 27 Nov '19

27 Nov '19

URL: https://github.com/SSSD/sssd/pull/932 Author: alexey-tikhonov Title: #932: SBUS: defer deallocation of sbus_watch_ctx Action: opened PR body: """ The following flow was causing use-after-free error: tevent_common_invoke_fd_handler(RW) -> sbus_watch_handler(RW) -> dbus_watch_handle(R) -> ...libdbus detects connection is closed... -> sbus_remove_watch() -> talloc_free(watch) -> ... get back to libdbus and back to sbus_watch_handler() -> "if (watch->dbus_write_watch) dbus_watch_handle(W)" => use-after-free To resolve an issue schedule deallocation of watch as immediate event. Resolves: https://pagure.io/SSSD/sssd/issue/2660 """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/932/head:pr932 git checkout pr932

2 24

[sssd PR#934][opened] SBUS: defer deallocation of sbus_watch_ctx
by alexey-tikhonov 27 Nov '19

27 Nov '19

URL: https://github.com/SSSD/sssd/pull/934 Author: alexey-tikhonov Title: #934: SBUS: defer deallocation of sbus_watch_ctx Action: opened PR body: """ The following flow was causing use-after-free error: tevent_common_invoke_fd_handler(RW) -> sbus_watch_handler(RW) -> dbus_watch_handle(R) -> ...libdbus detects connection is closed... -> sbus_watch_remove() -> talloc_free(watch_fd) -> ... get back to libdbus and back to sbus_watch_handler() -> "if (watch_fd->dbus_watch.write != NULL) dbus_watch_handle(W)" => use-after-free To resolve an issue schedule deallocation of watch as immediate event. Resolves: https://pagure.io/SSSD/sssd/issue/2660 """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/934/head:pr934 git checkout pr934

2 18

[sssd PR#945][comment] p11_child: add 'soft_ocsp' and 'soft_crl options
by sumit-bose 27 Nov '19

27 Nov '19

URL: https://github.com/SSSD/sssd/pull/945 Title: #945: p11_child: add 'soft_ocsp' and 'soft_crl options sumit-bose commented: """ New commit changes the way how an expired CA is created for tests. """ See the full comment at https://github.com/SSSD/sssd/pull/945#issuecomment-558987891

1 0

[sssd PR#945][synchronized] p11_child: add 'soft_ocsp' and 'soft_crl options
by sumit-bose 27 Nov '19

27 Nov '19

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

sssd-devel November 2019