[sssd PR#899][opened] sss_ptr_hash: pass new hash_entry_t to custom delete callback
by pbrezina
URL: https://github.com/SSSD/sssd/pull/899
Author: pbrezina
Title: #899: sss_ptr_hash: pass new hash_entry_t to custom delete callback
Action: opened
PR body:
"""
Setting `item->ptr = ptr` actually overwrote the original hash entry
stored in the hash. If this entry is looked up in the delete callback
it contains the overwritten value instead of the original.
Steps to reproduce:
```
1. Run sssd
2. Call e.g. `id user-1`
3. Terminate SSSD
```
You will see these `Invalid data type` messages.
(Snippet from domain log)
```
[dp_client_destructor] (0x0400): Removed IFP client
[sbus_signal_handler] (0x2000): Received D-Bus signal org.freedesktop.DBus.NameOwnerChanged on /org/freedesktop/DBus
[sbus_signal_handler] (0x2000): Received D-Bus signal org.freedesktop.DBus.NameOwnerChanged on /org/freedesktop/DBus
[sbus_senders_delete] (0x2000): Removing identity of sender [sssd.ifp]
[sbus_issue_request_done] (0x0400): org.freedesktop.DBus.NameOwnerChanged: Success
[sbus_senders_delete] (0x2000): Removing identity of sender [:1.5]
[sbus_issue_request_done] (0x0400): org.freedesktop.DBus.NameOwnerChanged: Success
[sbus_dispatch_reconnect] (0x0400): Connection lost. Terminating active requests.
[sss_ptr_hash_check_type] (0x0020): Invalid data type detected. Expected [struct sss_ptr_hash_value], got [struct sbus_connection].
[sss_ptr_hash_check_type] (0x0020): Invalid data type detected. Expected [struct sss_ptr_hash_value], got [struct sbus_connection].
```
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/899/head:pr899
git checkout pr899
4 years, 6 months
[sssd PR#903][opened] Gpo man page updates
by mzidek-rh
URL: https://github.com/SSSD/sssd/pull/903
Author: mzidek-rh
Title: #903: Gpo man page updates
Action: opened
PR body:
"""
Hi, this PR contains two patches. One is from another PR (already acked by me and does not need a review, I just have it here to avoid conflicts and want to finally push it. It is from our probably oldest PR, that is still not merged https://pagure.io/SSSD/sssd/pull-request/3320). I will try to merge the patches from that PR together with some other GPO patches, but this PR is just about the man page changes.
The second patch adds a note to the man page that current version of GPO does not support built-in groups in AD.
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/903/head:pr903
git checkout pr903
4 years, 6 months
[sssd PR#906][opened] memcache: Stop using the word fastcache for memcache
by mzidek-rh
URL: https://github.com/SSSD/sssd/pull/906
Author: mzidek-rh
Title: #906: memcache: Stop using the word fastcache for memcache
Action: opened
PR body:
"""
This patch removes the word fastche from our codebase.
We do not reffer to the fast in-memory mmaped cache consistantly.
Sometimes we call it fastcache, sometimes memcache and sometimes
mmap cache.
While we can not get rid of memcache, because it is rooted
in some config option names and in the documentation and
mmap cache is used a lot internally in our code, so getting
rid of that would require a lot of code changes, we can
easyly get rid of the 'fastcache' word because it is
only in a handful of places.
I think we should really stick to calling it memcache in
the documentation and debug messages and ideally also in
code comments to avoid confusion.
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/906/head:pr906
git checkout pr906
4 years, 6 months
[sssd PR#858][opened] ldap: do not store empty attribute with ldap_rfc2307_fallback_to_local_users = true
by pbrezina
URL: https://github.com/SSSD/sssd/pull/858
Author: pbrezina
Title: #858: ldap: do not store empty attribute with ldap_rfc2307_fallback_to_local_users = true
Action: opened
PR body:
"""
This caused an error when saving local user as a fallback:
```
[sdap_save_user] (0x0400): Storing info for user testuser(a)ldap.vm
[sysdb_ldb_msg_difference] (0x2000): Added attr [gecos] to entry [name=testuser(a)ldap.vm,cn=users,cn=ldap.vm,cn=sysdb]
[sysdb_set_cache_entry_attr] (0x0080): ldb_modify failed: [Invalid attribute syntax](21)[Element gecos has empty attribute in ldb message (name=testuser(a)ldap.vm,cn=users,cn=ldap.vm,cn=sysdb)!]
[sysdb_set_cache_entry_attr] (0x0040): Error: 22 (Invalid argument)
[sysdb_set_entry_attr] (0x0080): Cannot set attrs for name=testuser(a)ldap.vm,cn=users,cn=ldap.vm,cn=sysdb, 22 [Invalid argument]
[sysdb_store_user] (0x0040): Cache update failed: 22
[sysdb_store_user] (0x0400): Error: 22 (Invalid argument)
[sdap_save_user] (0x0020): Failed to save user [testuser(a)ldap.vm]
```
Steps to reproduce:
1. create local user `testuser`
2. add it to LDAP group memberUid
3. set `passwd: sss files`, `group: sss files` (sss must be before files)
4. set enable_files_domain = false and ldap_rfc2307_fallback_to_local_users = true
5. run sssd
6. id testuser
-> it does not contain the LDAP group without the patch
Resolves:
https://pagure.io/SSSD/sssd/issue/4013
Note: this fix only the case when the nsswitch order is `sss files` but no files domain is available.
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/858/head:pr858
git checkout pr858
4 years, 6 months
[sssd PR#898][opened] util/server: amended close_low_fds()
by alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/898
Author: alexey-tikhonov
Title: #898: util/server: amended close_low_fds()
Action: opened
PR body:
"""
Rewrote close_low_fds() to use freopen() as it fits better here
and some flags passed to open() previously didn't make a sense.
Also fixed a number of identical Coverity issues:
```
Error: RESOURCE_LEAK (CWE-772):
sssd-2.2.3/src/util/server.c:58: open_fn: Returning handle opened by "open". [Note: The source code implementation of the function has been overridden by a user model.]
sssd-2.2.3/src/util/server.c:58: var_assign: Assigning: "fd" = handle returned from "open("/dev/null", 1, 0)".
sssd-2.2.3/src/util/server.c:56: overwrite_var: Overwriting handle "fd" in "fd = open("/dev/null", 2, 0)" leaks the handle.
54| library routines writing to stdout etc. won't cause havoc */
55| for (i = 0; i < 3; i++) {
56|-> fd = open("/dev/null", O_RDWR, 0);
57| if (fd < 0)
58| fd = open("/dev/null", O_WRONLY, 0);
```
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/898/head:pr898
git checkout pr898
4 years, 6 months
[sssd PR#901][opened] Update sss_ssh.c
by alexal
URL: https://github.com/SSSD/sssd/pull/901
Author: alexal
Title: #901: Update sss_ssh.c
Action: opened
PR body:
"""
SSH: Adds a message to the syslog if an SSH key is malformed
If an SSH key contains trailing whitespace (or newlines), it will be considered as malformed by sss_ssh_format_pubkey() function. With the current version the only way to detect that problem is to enable --debug option for /usr/bin/sss_ssh_authorizedkeys utility. I'm adding an additional message to the syslog which will help to determine such problems without enabling debug.
Resolves: https://pagure.io/SSSD/sssd/issue/3864
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/901/head:pr901
git checkout pr901
4 years, 6 months