[sssd PR#908][opened] ifp: implement connection-wide access check
by pbrezina
URL: https://github.com/SSSD/sssd/pull/908
Author: pbrezina
Title: #908: ifp: implement connection-wide access check
Action: opened
PR body:
"""
Currently only a small subset of infopipe methods performed access check.
This change makes sure that we do this check global for everything.
Steps to reproduce:
1. Call an infopipe method as a user not-listed in [ifp] allowed_uids
2. Without the patch the access is granted
E.g.
```
$ dbus-send --print-reply --system --dest=org.freedesktop.sssd.infopipe /org/freedesktop/sssd/infopipe/Users org.freedesktop.sssd.infopipe.Users.FindByName string:user-1
```
Resolves:
https://pagure.io/SSSD/sssd/issue/4105
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/908/head:pr908
git checkout pr908
4 years, 5 months
New in the project & problem
by Iker Pedrosa
Hi team,
I'm new to the project and I have been looking at the documentation that is available in pagure on how to start contributing to it. So far I have been able to configure, compile, install and launch the unit tests but I'm stuck with the integration tests. Whenever I execute the command to launch them (make intgcheck) I get the following error:
You must have the header file http_parser.h installed to build sssd
with secrets responder. If you want to build sssd without secret responder
then specify --without-secrets when running configure.
The problem is that I don't know if I should deactivate secrets responder. Which would be the impact if I disable it? I've been reading the man page and it states that this is a way of not exposing sensitive key material, but it's not clear for me if I would have this type of data in an integration test. Moreover, how do I apply this configuration? Am i right if I suppose that it should be applied when configuring the compilation (reconfig --without-secrets && chmake)?
4 years, 5 months
[sssd PR#918][comment] Add support for NSS hosts database lookup.
by sumit-bose
URL: https://github.com/SSSD/sssd/pull/918
Title: #918: Add support for NSS hosts database lookup.
sumit-bose commented:
"""
Hi @scabrero,
thank you very much for this substantial contribution.
May I asked you to fix the Python pep8 issues identified by the CI test so that the other CI tests can be run?
For your convenience I add them here as well:
```
Start: Mon Oct 28 15:41:33 UTC 2019
+ find . -path ./src/config -prune -o -name '*.py' -exec pep8 --ignore=E121,E123,E126,E226,E24,E704,W503,W504,W605,E722 '{}' +
./src/tests/intg/ds_openldap.py:278:80: E501 line too long (84 > 79 characters)
./src/tests/intg/test_resolver.py:37:1: E265 block comment should start with '# '
./src/tests/intg/test_resolver.py:41:1: E302 expected 2 blank lines, found 1
./src/tests/intg/test_resolver.py:77:80: E501 line too long (84 > 79 characters)
./src/tests/intg/test_resolver.py:208:32: E251 unexpected spaces around keyword / parameter equals
./src/tests/intg/test_resolver.py:208:34: E251 unexpected spaces around keyword / parameter equals
./src/tests/intg/test_resolver.py:213:32: E251 unexpected spaces around keyword / parameter equals
./src/tests/intg/test_resolver.py:213:34: E251 unexpected spaces around keyword / parameter equals
./src/tests/intg/sssd_hosts.py:31:1: E302 expected 2 blank lines, found 1
./src/tests/intg/sssd_hosts.py:38:1: E302 expected 2 blank lines, found 1
./src/tests/intg/sssd_nss.py:32:1: E302 expected 2 blank lines, found 1
./src/tests/intg/sssd_nss.py:51:1: E302 expected 2 blank lines, found 1
./src/tests/intg/sssd_nss.py:60:1: E302 expected 2 blank lines, found 1
./src/tests/intg/sssd_nss.py:70:1: E302 expected 2 blank lines, found 1
./src/tests/intg/ldap_ent.py:150:26: E201 whitespace after '('
./src/tests/intg/ldap_ent.py:150:57: E202 whitespace before ')'
End: Mon Oct 28 15:41:36 UTC 2019
```
bye,
Sumit
"""
See the full comment at https://github.com/SSSD/sssd/pull/918#issuecomment-547020549
4 years, 6 months
[sssd PR#907][opened] Update README.md
by alexal
URL: https://github.com/SSSD/sssd/pull/907
Author: alexal
Title: #907: Update README.md
Action: opened
PR body:
"""
A few changes in README.md file:
1. Google+ is no longer available for consumer (personal) and brand accounts. I've removed the link to Google+ page as that link is no longer available.
2. I've added a link to a COPYING file.
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/907/head:pr907
git checkout pr907
4 years, 6 months
[sssd PR#883][opened] Minor fixes to util/sss_krb5
by alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/883
Author: alexey-tikhonov
Title: #883: Minor fixes to util/sss_krb5
Action: opened
PR body:
"""
Main purpose of this patches is to resolve: https://pagure.io/SSSD/sssd/issue/4081
It also fixes one coverity issue:
```
Error: DEADCODE (CWE-561):
sssd-2.2.3/src/util/sss_krb5.c:375: cond_const: Condition "(kt_err = krb5_kt_next_entry(ctx, keytab, &entry, &cursor)) == 0", taking true branch. Now the value of "kt_err" is equal to 0.
sssd-2.2.3/src/util/sss_krb5.c:406: const: At condition "kt_err != 0", the value of "kt_err" must be equal to 0.
sssd-2.2.3/src/util/sss_krb5.c:406: dead_error_condition: The condition "kt_err != 0" cannot be true.
sssd-2.2.3/src/util/sss_krb5.c:406: dead_error_line: Execution cannot reach the expression "kt_err != -1765328202L" inside this statement: "if (kt_err != 0 && kt_err !...".
# 404|
# 405| /* check if we got any errors from krb5_kt_next_entry */
# 406|-> if (kt_err != 0 && kt_err != KRB5_KT_END) {
# 407| DEBUG(SSSDBG_CRIT_FAILURE, "Error while reading keytab.\n");
# 408| goto done;
```
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/883/head:pr883
git checkout pr883
4 years, 6 months