[sssd PR#483][opened] Password change with two factor authentication
by sumit-bose
URL: https://github.com/SSSD/sssd/pull/483
Author: sumit-bose
Title: #483: Password change with two factor authentication
Action: opened
PR body:
"""
If two factor authentication is enforced both authentication factors are
needed to update or change the long term password. This means that during
the PAM chauthok operation it has to be determined if two factor
authentication is enable for the user and the user must be prompted
accordingly.
Typically in the first step of the chauthok operation (PAM_PRELIM_CHECK)
the current password is verified before asking the user for a new password.
With two factor authentication this has to be skipped because the one-time
factor would then be invalid to authenticate the actual password change.
In krb5_child if the long term Kerberos password is expired the available
pre-authentication types for the user should be checked by requesting the
kadmin/changepw principal.
Related to https://pagure.io/SSSD/sssd/issue/3585
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/483/head:pr483
git checkout pr483
6 years, 2 months
[sssd PR#487][opened] SYSDB: Fix sysdb_search_by_name() for looking up groups in MPG domains
by jhrozek
URL: https://github.com/SSSD/sssd/pull/487
Author: jhrozek
Title: #487: SYSDB: Fix sysdb_search_by_name() for looking up groups in MPG domains
Action: opened
PR body:
"""
If a group was being looked by using sysdb_search_by_name() in a MPG
domain, the code would search only for group objects -- but in a MPG
domain, there may be none, the groups are typically inferred from a user
object.
This could have caused issues e.g. for IPA code with the following
sequence:
getent group aduser(a)windows.domain
getent passwd aduser(a)windows.domain
The former would fail to add the fallback subdomain homedir and the latter
would then return a user entry without a homedir, with libc falling back to
the "/" homedir.
NOTE: The patch has no unit test. I'll add one when the approach is
confirmed as correct by another developer.
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/487/head:pr487
git checkout pr487
6 years, 3 months
Design page: Automatic private group creation for the LDAP provider
by Jakub Hrozek
Hi,
I wrote a design page about exposing the functionality that creates the
user private groups based on the user entry only:
https://pagure.io/fork/jhrozek/SSSD/docs/blob/mpg/f/design_pages/auto_pri...
For your convenience, I'm also copying the design text in the RST format
below.
Once the design is approved, I'll propose a PR against the sssd/docs
repository.
Automatic Private Groups
========================
Related ticket(s):
------------------
https://pagure.io/SSSD/sssd/issue/1872
Problem statement
-----------------
This change will enable SSSD to automatically generate private groups for
users based on the UID number without the group actually being present as
an LDAP object.
Use cases
---------
The primary use-case is ease of management. The LDAP administrator will only
create the user object and add the user to supplementary groups as needed.
This has two advantages:
* There is one less object to manage and keep in sync with the user
* In AD environments, it is not possible to create a user and a group
with the same samAccountName, therefore even manually creating the private
groups requires the admin to remap the group attribute to a non-default one
since by default both users and groups use samAccountName.
Overview of the solution
------------------------
Most of the low-level functionality in the sysdb layer had been developed
for many years for use in the ``local`` provider. At the same time, there
are also most of the infrastrucure ready in the LDAP provider, because
the automatic private groups are used by default already for trusted domains.
At the moment, the functionality is enabled internally by an option called
``mpg``, short for Magic-Private-Groups. On a high level, the private groups
are not created in the SSSD cache at all, but the work is done by the NSS
responder which generates the group reply based on the user object
only. However, since the ``mpg`` option was always set for truste
Therefore, the majority of the work will be exposing the option in
configuration and making sure all codepaths work equally well for joined
domains as they do for trusted domains.
Implementation details
----------------------
A new option needs to be added that would control the user private group
creation. In the past, we've had an option called ``magic_private_groups``
and the internal boolean flag inside the ``sss_domain_info`` structure is
still called ``mpg``.
Instead of resurrecting the old option, we should introduce a newly named
option that would be understood by admins better, such as
``auto_private_groups``. The new option must be read on SSSD startup and set
the ``sss_domain_info->mpg`` flag, which is currently auto-enabled with
sudomains only.
The code branch that saves the user (currently ``sdap_save_user``) must be
extended to allow setting the GID number to be the same as UID number for
any domain that sets the ``mpg`` flag. Care must be taken to store the
original GID number (if any) to the ``SYSDB_PRIMARY_GROUP_GIDNUM`` attribute
which is then used by the NSS responder to add the original primary GID
as a supplementary group.
Finally, the group-by-GID LDAP request in the LDAP provider must be extended
to make sure that if a private group GID is requested before the user is,
the group request will also turn the group-by-GID request to a user-by-UID
request which would save the user object which would then allow the NSS responder
to auto-generate the group reply.
Configuration changes
---------------------
A new option ``auto_private_groups`` will be introduced. At the moment, it
will only be possible to set the option for the joined domains as the trusted
domains always create the private groups already by default. Therefore
the only viable usage of this new option in a trusted domain would be
`disabling` the functionality, which is out of scope of this RFE.
The ``auto_private_groups`` option will default to ``false``.
The new option must document that currently the cache must be removed when
changing the option value.
How To Test
-----------
The primary use-cases are SSSD being a client of a generic LDAP server
and SSSD on a Linux machine directly joined to an AD domain with
``id_provider=ad``.
In both cases, setting the ``auto_private_groups`` option to ``true``
should result in the ``initgroups`` call returning the primary GID number
of the user with the same value and resolving to the same name as the
primary UID namber and the username.
Other intefaces should produce symmetrical results, although at least in
the case of the D-Bus based IFP interface, is it currently not the case,
see `ticket #3543 <https://pagure.io/SSSD/sssd/issue/3543>`_.
For example, here is an output of a test user with private groups autogenerated::
id puser(a)win.trust.test
uid=20000(puser(a)win.trust.test) gid=20000(puser(a)win.trust.test) groups=20000(puser@win.trust.test),20002(user1_group2@win.trust.test),20001(user1_group1@win.trust.test),10000(pgroup(a)win.trust.test)
and without::
id puser(a)win.trust.test
uid=20000(puser(a)win.trust.test) gid=10000(pgroup(a)win.trust.test) groups=10000(pgroup@win.trust.test),20001(user1_group1@win.trust.test),20002(user1_group2(a)win.trust.test)
Note that in the case of the private groups being generated, the original
GID number is turned into a supplementary group by the initgroups call.
How To Debug
------------
There's not much extra debugging added for this feature. Debugging this
feature should amount to the usual checking of the debug logs. In addition,
the cache can be inspected with the ``ldbsearch`` tool to make sure all the
groups are saved as expected as well as the ``SYSDB_PRIMARY_GROUP_GIDNUM``
attribute.
Authors
-------
* Jakub Hrozek <jhrozek(a)redhat.com>
6 years, 3 months
[sssd PR#491][opened] AD: Inherit the MPG setting from the main domain
by jhrozek
URL: https://github.com/SSSD/sssd/pull/491
Author: jhrozek
Title: #491: AD: Inherit the MPG setting from the main domain
Action: opened
PR body:
"""
Resolves: https://pagure.io/SSSD/sssd/issue/3613
If the auto_private_groups option was set in the domain section for direct
integration, it only had an effect on the joined domain, not any of the
subdomains, so requesting a user from the child domain would look like
this:
```
$ id childuser(a)child.win.trust.test
uid=30000(childuser(a)child.win.trust.test) gid=40000(usergroup(a)child.win.trust.test) groups=40000(usergroup(a)child.win.trust.test) ```
```
The expected result, visible
after this patch is:
```
$ id childuser(a)child.win.trust.test
uid=30000(childuser(a)child.win.trust.test) gid=30000(childuser(a)child.win.trust.test) groups=30000(childuser@child.win.trust.test),40000(usergroup(a)child.win.trust.test)
```
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/491/head:pr491
git checkout pr491
6 years, 3 months
[sssd PR#484][opened] SDAP: skip builtin AD groups in sdap_save_grpmem()
by sumit-bose
URL: https://github.com/SSSD/sssd/pull/484
Author: sumit-bose
Title: #484: SDAP: skip builtin AD groups in sdap_save_grpmem()
Action: opened
PR body:
"""
While processing group memberships SSSD might accidentally save builtin
or other well known AD groups. With this patch those groups are skipped
similar as e.g. in sdap_save_group().
Resolves https://pagure.io/SSSD/sssd/issue/3610
There are other ways to solve the issue reported in ticket #3610, e.g. making
sure 'isPosix=False' is added to the group object in the cache. But since the
builtin groups are also ignored in sdap_save_group() I think this way is
currently more consistent. Long term I think we should find a way to assign
POSIX IDs to the well-known SIDs so that we can treat them as Posix objects.
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/484/head:pr484
git checkout pr484
6 years, 3 months