[sssd PR#241][opened] FleetCommander Integration
by fidencio
URL: https://github.com/SSSD/sssd/pull/241
Author: fidencio
Title: #241: FleetCommander Integration
Action: opened
PR body:
"""
This patch series contains:
- some refactoring done on access module (and, consequently, on HBAC) in order to reuse a some code in the session module (an, consequently, on FleetCommander code);
- the new session module that provides the FleetCommander Integration;
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/241/head:pr241
git checkout pr241
6 years, 7 months
[sssd PR#211][opened] IFP: Fix of limit = 0 (unlimited result)
by celestian
URL: https://github.com/SSSD/sssd/pull/211
Author: celestian
Title: #211: IFP: Fix of limit = 0 (unlimited result)
Action: opened
PR body:
"""
If we set limit to 0 it means that result is unlimited. Internally we
restrict number of result by allocation of result array.
In unlimited case there was a bug and zero array was allocated.
This fix allocates neccessary array when we know real result size.
Resolves:
https://pagure.io/SSSD/sssd/issue/3306
How to test (this reproducer needs #208 "IFP: Filter with * in Users.ListByName method" applied)
```
systemctl daemon-reload
sudo su -c "truncate -s0 /var/log/sssd/*.log"
sudo su -c "rm -f /var/lib/sss/db/*"
sudo su -c "rm -f /var/lib/sss/mc/*"
sudo systemctl restart sssd.service
sudo su -c "truncate -s0 /var/log/sssd/*.log"
dbus-send --system --print-reply --dest=org.freedesktop.sssd.infopipe \
/org/freedesktop/sssd/infopipe/Users \
org.freedesktop.sssd.infopipe.Users.ListByName \
string:"*" uint32:"0"
dbus-send --system --print-reply --dest=org.freedesktop.sssd.infopipe \
/org/freedesktop/sssd/infopipe/Groups \
org.freedesktop.sssd.infopipe.Groups.ListByName \
string:"*" uint32:"100"
dbus-send --system --print-reply --dest=org.freedesktop.sssd.infopipe \
/org/freedesktop/sssd/infopipe/Users \
org.freedesktop.sssd.infopipe.Users.ListByDomainAndName \
string:"domain.cygnus" string:"*" uint32:"100"
```
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/211/head:pr211
git checkout pr211
6 years, 7 months
[sssd PR#354][opened] libwbclient: Fix warning statement with no effect
by lslebodn
URL: https://github.com/SSSD/sssd/pull/354
Author: lslebodn
Title: #354: libwbclient: Fix warning statement with no effect
Action: opened
PR body:
"""
src/sss_client/libwbclient/wbc_pam_sssd.c: In function ‘wbcAuthenticateUserEx’:
src/sss_client/libwbclient/wbc_pam_sssd.c:52:5: error: statement with no effect [-Werror=unused-value]
WBC_ERR_WINBIND_NOT_AVAILABLE;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/sss_client/libwbclient/wbc_pam_sssd.c:53:1: error: control reaches end of non-void function [-Werror=return-type]
}
^
`WBC_SSSD_NOT_IMPLEMENTED` is not an error code but also macro which can log to syslog
and then return `WBC_ERR_NOT_IMPLEMENTED`
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/354/head:pr354
git checkout pr354
6 years, 8 months
[sssd PR#353][opened] libwbclient: Change return code for wbcAuthenticateUserEx
by lslebodn
URL: https://github.com/SSSD/sssd/pull/353
Author: lslebodn
Title: #353: libwbclient: Change return code for wbcAuthenticateUserEx
Action: opened
PR body:
"""
Samba-4.6 change behaviour of few functions
New version of code make sure session info for user is stored in cache.
It is a performance optimisation to prevent contacting KDC for each
session. More details in samba bug
https://bugzilla.samba.org/show_bug.cgi?id=11259
Old return code WBC_SSSD_NOT_IMPLEMENTED was translated
to NT_STATUS_LOGON_FAILURE which caused many failures.
[2017/08/21 11:34:15.044321, 5, pid=27742, effective(0, 0), real(0, 0)]
../libcli/security/security_token.c:53(security_token_debug)
Security token: (NULL)
[2017/08/21 11:34:15.044330, 5, pid=27742, effective(0, 0), real(0, 0)]
../source3/auth/token_util.c:640(debug_unix_user_token)
UNIX token of user 0
Primary group is 0 and contains 0 supplementary groups
[2017/08/21 11:34:15.044349, 4, pid=27742, effective(0, 0), real(0, 0)]
../source3/smbd/sec_ctx.c:439(pop_sec_ctx)
pop_sec_ctx (0, 0) - sec_ctx_stack_ndx = 0
[2017/08/21 11:34:15.044360, 1, pid=27742, effective(0, 0), real(0, 0)]
../source3/smbd/sesssetup.c:290(reply_sesssetup_and_X_spnego)
Failed to generate session_info (user and group token) for session
setup: NT_STATUS_LOGON_FAILURE
Resolves:
https://pagure.io/SSSD/sssd/issue/3461
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/353/head:pr353
git checkout pr353
6 years, 8 months
debugging adcli info - short name not returned
by smfrench@gmail.com
In one of our test domains, we noticed that the short name of the domain was not being returned by "adcli info" (it is visible in the output of "net rpc info" though and it is clearly configured in Windows and can be seen in the GUI and CLI of Windows).
Running "adcli info --verbose" we see only a few lines about contacting servers, but nothing obvious to me.
Any ideas about common reasons that adcli info can't return short domain name from a particular win2K8 server but ok to others (while "net" can always return it). Note that joining the domain (via realm) does work - even though can't get short name
6 years, 8 months
RFC: 1.15.4 cleanup
by Jakub Hrozek
Hi,
1.15.4 will be released by the end of this months in a time-based
fashion. But obviously, the milestone is too big, so we need to decide
where do we push the tickets to.
I added tags to the tickets with my proposed cleanup:
- move to 1.16:
https://pagure.io/SSSD/sssd/roadmap?status=Open&tag=cleanup-one-sixteen&n...
- move to 'future releases' https://pagure.io/SSSD/sssd/roadmap?status=Open&tag=cleanup-future&no_sto...
- move to 'patches welcome'
https://pagure.io/SSSD/sssd/roadmap?status=Open&tag=cleanup-patches-welco...
It would be nice to hear some feedback from others before I move the
tickets.
About the tickets that are proposed to stay in 1.15 -- most of them have
PRs available, but those that we won't finish should IMO be rolled to
1.15.5, because who knows when will 1.16.0 be released and especially
the KCM related fixes are important to be included in Fedora around
Sep-5, so I think we might want to do another release a week after .4..
And finally, about the 1.16 milestone -- I suggest we start chopping on
that one as developers shake off 1.15.x tasks. We should do a time-based
release by the end of September, then one by the end of October and see
how many tickets are left..
6 years, 8 months
[sssd PR#350][opened] intg: Increase startup timeouts for kcm and secrets
by lslebodn
URL: https://github.com/SSSD/sssd/pull/350
Author: lslebodn
Title: #350: intg: Increase startup timeouts for kcm and secrets
Action: opened
PR body:
"""
In cwrap environment, we start sssd_kcm and sssd_secrets ourself
and not by systemd socket activation. Our approach is to wait a second in
a loop till socket is available. However sometimes 1 second is not enough.
Patch increases wait timeout from 1 second to 10 and it seems to be enough even
when processes were executed with valgrind.
Traceback (most recent call last):
File "src/tests/intg/test_secrets.py", line 419, in setup_for_cli_timeout_test
return create_sssd_secrets_fixture(request)
File "src/tests/intg/test_secrets.py", line 82, in create_sssd_secrets_fixture
assert os.path.exists(sock_path)
AssertionError: assert False
+ where False = <function exists at 0x7f6c1cf520c8>('/tmp/sssd-intg.cdv0namx/var/run/secrets.socket')
+ where <function exists at 0x7f6c1cf520c8> = <module 'posixpath' from '/usr/lib64/python2.7/posixpath.pyc'>.exists
+ where <module 'posixpath' from '/usr/lib64/python2.7/posixpath.pyc'> = os.path
Resolves:
https://pagure.io/SSSD/sssd/issue/3481
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/350/head:pr350
git checkout pr350
6 years, 8 months