[sssd PR#230][opened] Failure to filter out AD subdomain with flatname is used
by justin-stephenson
URL: https://github.com/SSSD/sssd/pull/230
Author: justin-stephenson
Title: #230: Failure to filter out AD subdomain with flatname is used
Action: opened
PR body:
"""
Ticket: https://pagure.io/SSSD/sssd/issue/3365
SSSD fails to filter out the child domain it is connected to when domain flatname is used instead of fully qualified domain name in `sssd.conf`, this leads to creation of an empty subdomain.
After the patch, no duplicate subdomain is created. Tested by performing `id` against user in connected-to child domain(used 2 AD domains:root and child for this).
```
[sssm_ad_subdomains_init] (0x2000): Initializing AD subdomains handler
[new_subdomain] (0x0400): Creating [AD.JSTEPHEN] as subdomain of [winchld]!
[ad_subdomains_process] (0x0400): Enabling subdomain WINCHLD.AD.JSTEPHEN
[ad_subdomains_process] (0x2000): Not including primary domain winchld in the subdomain list
[ad_subdomains_refresh_done] (0x0400): Subdomains refreshed.
```
I wrote a test for this but I may have gotten some talloc heirarchy incorrect so please let me know if there is a problem to fix here.
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/230/head:pr230
git checkout pr230
6 years, 11 months
[sssd PR#272][opened] cache_req: Fix warning maybe-uninitialized
by lslebodn
URL: https://github.com/SSSD/sssd/pull/272
Author: lslebodn
Title: #272: cache_req: Fix warning maybe-uninitialized
Action: opened
PR body:
"""
the variable `req` could be used uninitialized in done section if talloc_new returns `NULL`
src/responder/common/cache_req/cache_req_search.c:
In function 'cache_req_search_done':
src/responder/common/cache_req/cache_req_search.c:467:9:
error: 'req' may be used uninitialized in this function
[-Werror=maybe-uninitialized]
tevent_req_error(req, ret);
^
src/responder/common/cache_req/cache_req_search.c:424:24:
note: 'req' was declared here
struct tevent_req *req;
^
cc1: all warnings being treated as errors
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/272/head:pr272
git checkout pr272
6 years, 11 months
Merging sss_cache and sss_debuglevel into sssctl
by Justin Stephenson
Hello, I wanted to check if anyone has objections or concerns with
moving existing code for sss_cache and sss_debuglevel into sssctl for
ticket #3057 - Merge existing command line tools into sssctl.
The deprecated tools will become shell wrappers to the sssctl commands
implementing the same functionality so I think it should be transparent
to the end-user.
Kind regards,
Justin Stephenson
6 years, 11 months