[sssd PR#399][opened] Backport of PR#57 to SSSD-1.13
by sumit-bose
URL: https://github.com/SSSD/sssd/pull/399
Author: sumit-bose
Title: #399: Backport of PR#57 to SSSD-1.13
Action: opened
PR body:
"""
Besides cherry-picking the patches some changes were needed to make the patches
work on 1.13. To make review easier I didn't squash the changes in but put them
in a separate patch. This might cause issues with the CI, so my plan is to
squash the changes in after the first round of review.
SSSD-1.13 still uses different names in the cache for the configured domain
and sub-domains, hence some name related calls had to be adjusted.
dp_target_enabled() is not available in 1.13 and I think just checking the
schema would be sufficient.
In more recent version of SSSD sysdb_group_membership_mod() treats the
domain argument only as the domain of the group and the domain of the
members are derived from the fully-qualified name. With this patch the
domain of the members is determined as well to allow to add members of
different domains to a group. This required a small addition to the unit
tests as well.
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/399/head:pr399
git checkout pr399
6 years, 5 months
[sssd PR#412][opened] Gpo contributed patches
by mzidek-rh
URL: https://github.com/SSSD/sssd/pull/412
Author: mzidek-rh
Title: #412: Gpo contributed patches
Action: opened
PR body:
"""
Hi, I am moving the patches from this PR:
https://pagure.io/SSSD/sssd/pull-request/3320
Here on GH. The issue was stalled for a long time, and I do not think it is good idea to ask for changes in the patches after 7 months. So I decided to immediately change all the problems I found and squshed them into the patches in this PR.
There were no big issues with the patches:
- I rebased it on top of the current master
- added missing include for toupper function
- the debug message format was not the same as we use on other places (note that this change was difficult to squash for each patch, so not all patches are 'clean', because I squashed all the debug message issues to the GPO: Improve logging of GPO... patch, however the result after applying all patches is as expected)
- I added some comments
- there were some memory leaks (missing frees)
Notice that I am not the author of the patches, only reviewer.
The patches as they are in this PR LGTM. I tested them to check if something is broken (manually.. sigh) and now I am waiting for the CI results.
There was one issue occuring when I tested these patches and I originally though the is caused by these patches, but now I know it is not. The issue is that I did not have GPOs distributed to all DCs and it looks like SSSD randomly picks one DC and contacts it (even though it was DC from subdomain) so it could not always find all the GPOs (it looked for them on wrong DCs, where they were not). Other then that I encountered no issues with the patches, so it is ACK from me (tentative).
However since I am not native speaker and the last patch is MAN page change, I would appreciate second pair of eyes for that patch. Second pair of eyes for the rest of the patches would also be appreciated :)
However if nobody raises any issues I will ACK it soon (given the tests will pass).
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/412/head:pr412
git checkout pr412
6 years, 5 months
[sssd PR#424][comment] TOOLS: Add a new sssctl command access-report
by jhrozek
URL: https://github.com/SSSD/sssd/pull/424
Title: #424: TOOLS: Add a new sssctl command access-report
jhrozek commented:
"""
one:
```
diff --git a/src/tools/sssctl/sssctl_access_report.c b/src/tools/sssctl/sssctl_access_report.c
index 25889f582..8cf1a8a87 100644
--- a/src/tools/sssctl/sssctl_access_report.c
+++ b/src/tools/sssctl/sssctl_access_report.c
@@ -282,15 +282,17 @@ static errno_t refresh_hbac_rules(struct sss_tool_ctx *tool_ctx,
return ENOMEM;
}
- path = sbus_opath_compose(tool_ctx, IFP_PATH_DOMAINS, domain->name);
+ path = sbus_opath_compose(tmp_ctx, IFP_PATH_DOMAINS, domain->name);
if (path == NULL) {
printf(_("Out of memory!\n"));
- return ENOMEM;
+ ret = ENOMEM;
+ goto done;
}
error = sssctl_sifp_init(tool_ctx, &sifp);
if (error != SSS_SIFP_OK) {
sssctl_sifp_error(sifp, error, "Unable to connect to the InfoPipe");
+ ret = EIO;
goto done;
}
```
two:
```
diff --git a/src/providers/ipa/ipa_access.c b/src/providers/ipa/ipa_access.c
index 110cde26b..de9f68170 100644
--- a/src/providers/ipa/ipa_access.c
+++ b/src/providers/ipa/ipa_access.c
@@ -711,7 +711,6 @@ ipa_refresh_access_rules_send(TALLOC_CTX *mem_ctx,
struct ipa_refresh_access_rules_state *state;
struct tevent_req *subreq;
struct tevent_req *req;
- errno_t ret;
DEBUG(SSSDBG_TRACE_FUNC, "Refreshing HBAC rules\n");
@@ -724,7 +723,7 @@ ipa_refresh_access_rules_send(TALLOC_CTX *mem_ctx,
subreq = ipa_fetch_hbac_send(state, params->ev, params->be_ctx, access_ctx);
if (subreq == NULL) {
- tevent_req_error(req, ret);
+ tevent_req_error(req, ENOMEM);
tevent_req_post(req, params->ev);
return req;
}
```
"""
See the full comment at https://github.com/SSSD/sssd/pull/424#issuecomment-345524613
6 years, 5 months