sssd-devel August 2016

sssd-devel@lists.fedorahosted.org

24 participants
132 discussions

[PATCH] SYSDB: Check changed virtual attributes before modified timestamp
by Lukas Slebodnik 10 Aug '16

10 Aug '16

ehlo, attached patch fixes acces denied after activating user in 389ds. Jakub had some comments/ideas in ticket but I think it's better to discuss about virtual attributes and timestamp cache on mailing list. LS

3 37

[PATCH] NSS: Use correct name for invalidating memory cache
by Lukas Slebodnik 10 Aug '16

10 Aug '16

ehlo, yet another patch which fixes issues caused by sysdb refactoring. reproducer: a) add user with two groups b) call id user c) add another group to user d) authenticate e) check tha id -G return 3 groups. I am looking forward to the pam_wrapper So we can test it in upstream. LS

3 7

The sorry state of code documentation
by Nikolai Kondrashov 10 Aug '16

10 Aug '16

Hi everyone, I've been acquainting myself with SSSD code the last few weeks. Particularly, the NSS responder, and what it uses down the stack. The SSSD code is sure complex and its asynchronous nature doesn't help. However, what struck me, and frustrated me the most, as a new reader of the code, was the meager amount of code documentation. In the absence of documentation, a piece of logic, such as processing a getpwnam request, requires traversing many functions, modules, and several programs. Sure, you can guess what a function does, based on its name and somewhat on arguments, but you can't be sure without reading it and the functions it calls, and often the functions those call in turn. Same goes with data structures: to understand them you need to read the code that creates and operates them. To the author code often seems obvious, but a new reader has a dozen questions: which state the passed object should be in, how does the function modify the object, where does it put its output, what else it affects, exactly what string should be that, what status codes the function can return and what will they mean, etc. Documentation cements the author's intention in the mind of the reader, freeing the memory and precious attention for understanding the code at hand, as opposed to requiring going deeper and deeper into the underlying code, where the reader eventually forgets why he or she is looking at it. Reading such complicated code as can be seen in SSSD without documentation is an exercise in frustration. We often speak about cooperation and getting more external contributors. However, we're not going to get many if they have such a mountain of code to climb without our help. We ourselves will be (and are) struggling to understand our own code, and will pay with lost time again and again when trying to modify or extend it. In short: it is NOT OK that SSSD code has no documentation. Put bluntly, it is sloppy engineering. I'm sure we can do better. If you have just a sentence describing each function and each of its arguments, understanding the code becomes considerably easier. You don't have to guess that much, and you don't have to verify your guesses and read so much more. Function documentation would often make reading its code unnecessary. A sentence for a data structure and each of its fields makes understanding the code operating it much easier. I suggest several measures which could be taken. 1. Require *every* new module/function/argument/structure/field to be documented. It must be at least a sentence for each. A module or a bigger data structure could warrant more. Describe module/function/structure overall, and each of its declarations/arguments/return values/fields. 2. Next level, documentation tax: if you touch anything, document it. Modified a module header? Add a short module description. Added or removed a field in a structure? Add structure and field descriptions. Changed a function? Document it. 3. Third level, documentation duty: document a whole existing module header of your choosing, say once a month. The format of documentation doesn't matter, as long as it's legible and agreed upon. I suggest Doxygen, but it can be anything else. We don't have to actually run the documentation extraction tool (such as "doxygen") on our code and use perfectly correct syntax (although that could be the next step). What matters is that documentation is there, it's uniform, and you don't have to think about the format when writing it. For example of how it can look see the attached patch where I tried to document some things (likely misunderstanding some) as I read the code. For more examples of what I mean see the tlog header files: https://github.com/Scribery/tlog/tree/master/include/tlog They are not the best example and there are many ways they can be improved (tell me please!), but if SSSD had just that it would be already awesome. Please tell me what you think, object, or suggest your own solutions! Thank you. Nick

4 13

[PATCH] intg: Allow to test netgroups
by Lukas Slebodnik 10 Aug '16

10 Aug '16

ehlo, attcheck patch is a python wrapper for netgroup lookups in sssd. LS

2 2

[PATCH] Add support for disabling netlink use
by Justin Stephenson 09 Aug '16

09 Aug '16

Hello, The attached patch fixes: https://fedorahosted.org/sssd/ticket/2860 This provides an option used primarily for testing purpose to ignore network status changes from the netlink interface(helpful when sssd should remaining in offline/online mode) =================================== Before the patch, restarting the network triggers sssd to go back online (Mon Aug 8 15:50:18 2016) [sssd] [route_msg_debug_print] (0x1000): route idx 1 flags 0 family 10 addr 2002:ac10::/28 (Mon Aug 8 15:50:18 2016) [sssd] [network_status_change_cb] (0x2000): A networking status change detected signaling providers to reset offline status (Mon Aug 8 15:50:18 2016) [sssd] [sbus_add_timeout] (0x2000): 0x21af1a0 (Mon Aug 8 15:50:18 2016) [sssd] [sbus_remove_timeout] (0x2000): 0x21af1a0 (Mon Aug 8 15:50:18 2016) [sssd] [sbus_dispatch] (0x4000): dbus conn: 0x21ba170 (Mon Aug 8 15:50:18 2016) [sssd] [sbus_dispatch] (0x4000): Dispatching. (Mon Aug 8 15:50:18 2016) [sssd] [message_type] (0x0200): netlink Message type: 24 (Mon Aug 8 15:50:18 2016) [sssd] [route_msg_debug_print] (0x1000): route idx 1 flags 0 family 10 addr 2002:c0a8::/32 (Mon Aug 8 15:50:18 2016) [sssd] [network_status_change_cb] (0x2000): A networking status change detected signaling providers to reset offline status (Mon Aug 8 15:50:18 2016) [sssd] [sbus_add_timeout] (0x2000): 0x21bd2a0 (Mon Aug 8 15:50:18 2016) [sssd] [sbus_remove_timeout] (0x2000): 0x21bd2a0 (Mon Aug 8 15:50:18 2016) [sssd] [sbus_dispatch] (0x4000): dbus conn: 0x21ba170 (Mon Aug 8 15:50:18 2016) [sssd] [sbus_dispatch] (0x4000): Dispatching. (Mon Aug 8 15:50:18 2016) [sssd] [message_type] (0x0200): netlink Message type: 24 After the patch, # pkill -USR1 sssd Restart the network, sssd remains offline # service network restart Test backend lookup with no cache shows backend is still offline # id aduser(a)ad.domain (Mon Aug 8 16:44:17 2016) [sssd[be[AD.JSTEPHEN]]] [sbus_dispatch] (0x4000): dbus conn: 0x1853d60 (Mon Aug 8 16:44:17 2016) [sssd[be[AD.JSTEPHEN]]] [sbus_dispatch] (0x4000): Dispatching. (Mon Aug 8 16:44:17 2016) [sssd[be[AD.JSTEPHEN]]] [sbus_message_handler] (0x2000): Received SBUS method org.freedesktop.sssd.dataprovider.getAccountInfo on path /org/freedesktop/sssd/dataprovider (Mon Aug 8 16:44:17 2016) [sssd[be[AD.JSTEPHEN]]] [sbus_get_sender_id_send] (0x2000): Not a sysbus message, quit (Mon Aug 8 16:44:17 2016) [sssd[be[AD.JSTEPHEN]]] [dp_attach_req] (0x0400): DP Request [Account #2]: New request. Flags [0x0001]. (Mon Aug 8 16:44:17 2016) [sssd[be[AD.JSTEPHEN]]] [dp_attach_req] (0x0400): Number of active DP request: 1 (Mon Aug 8 16:44:17 2016) [sssd[be[AD.JSTEPHEN]]] [_dp_req_recv] (0x0400): DP Request [Account #2]: Receiving request data. (Mon Aug 8 16:44:17 2016) [sssd[be[AD.JSTEPHEN]]] [dp_req_reply_gen_error] (0x0080): DP Request [Account #2]: Finished. Backend is currently offline. (Mon Aug 8 16:44:17 2016) [sssd[be[AD.JSTEPHEN]]] [dp_table_value_destructor] (0x0400): Removing [0:1:0x0001:1:1::AD.JSTEPHEN:name=myaduser@ad.jstephen] from reply table (Mon Aug 8 16:44:17 2016) [sssd[be[AD.JSTEPHEN]]] [dp_req_destructor] (0x0400): DP Request [Account #2]: Request removed. (Mon Aug 8 16:44:17 2016) [sssd[be[AD.JSTEPHEN]]] [dp_req_destructor] (0x0400): Number of active DP request: 0 (Mon Aug 8 16:44:17 2016) [sssd[nss]] [sss_dp_get_reply] (0x0010): The Data Provider returned an error [org.freedesktop.sssd.Error.DataProvider.Offline] Kind regards, Justin Stephenson

1 1

[PATCH] sssctl: use internal API to remove files
by Pavel Březina 09 Aug '16

09 Aug '16

3 6

which tickets do we need to close before releasing 1.14.1?
by Jakub Hrozek 09 Aug '16

09 Aug '16

I would say we want to include: https://fedorahosted.org/sssd/ticket/3110 - Access denied after activating user in 389ds https://fedorahosted.org/sssd/ticket/3120 - SSSD fails to start when ldap_user_extra_attrs contains mail https://fedorahosted.org/sssd/ticket/3101 - sssd does not start if sub-domain user is used with simple access provider When these are included, I would like to tag 1.14.1. Any other opinions?

2 1

[PATCH] UTILS: Fixing duplication of pid file declaration
by Petr Cech 09 Aug '16

09 Aug '16

Hello list, attached patch fixes duplication of pid file declaration. I hope that the util/util.h is the right place for it. Another opinion are welcome. Regards -- Petr^4 Čech

3 6

[PATCH] NSS: Do not check local users with disabled local_negative_timeout
by Lukas Slebodnik 09 Aug '16

09 Aug '16

ehlo, The simple reproducer is to use getent passwd,group with non-existing entry. Without the patch you will see that "/var/lib/sss/mc/passwd" is opened twice. Onece with mode "rw" opened by sssd_nss and the 2nd time with "r-" opened by sssd-client (getpwnam, getpwuid, getgrnam, getgrgid) LS

3 6

[PATCH] DP: Initialize D-Bus as soon as possible
by Pavel Březina 09 Aug '16

09 Aug '16

https://fedorahosted.org/sssd/ticket/3111

3 10

← Newer
1
...
8
9
10
11
12
13
14
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

sssd-devel August 2016