[PATCH] Guard against invalid DP messages
by Jakub Hrozek
Hi,
the two attached patches fix
https://fedorahosted.org/sssd/ticket/2861
The first removes dp_pam_err_to_string() completely. It was wrong to use
function that calls pam_strerror() for non-PAM callbacks and even worse
that the PAM callback itself didn't call dp_pam_err_to_string..
The second guards against similar mistakes in the future by checking for
valid UTF-8 string. I think we should do this because technically there
can be a 3rd party provider.
I also have another patch that reduced code duplication -- because I
suspect that copy-pasting was the original reason this bug was
introduced. But I need to test the patches more, because they touch all
callbacks..
8 years, 5 months
[PATCH] SSSD: Add a new command diag_cmd
by Jakub Hrozek
Hi,
I created this patch to try to diagnose an issue where sssd would
randomly restart on any of machines in a VM cluster without giving too
much advise why. I think it might be useful to merge in general.
8 years, 5 months
CONFIGURE: Bump AM_GNU_GETTEXT_VERSION
by Lukas Slebodnik
ehlo,
The function gettext was not detected properly with strict
cflags even thought it was part of glibc.
sh$ CFLAGS="-Werror" ./configure
sh$ grep gt_cv_func_gnugettext config.log
gt_cv_func_gnugettext1_libc=no
gt_cv_func_gnugettext1_libintl=no
sh$ objdump -T /lib64/libc.so.6 | grep gettext
000000000002fc60 w DF .text 0000000000000010 GLIBC_2.2.5 dcngettext
000000000002dc70 w DF .text 000000000000000f GLIBC_2.2.5 dcgettext
000000000002fc80 w DF .text 0000000000000016 GLIBC_2.2.5 ngettext
000000000002dc90 w DF .text 000000000000000f GLIBC_2.2.5 gettext
000000000002dc70 g DF .text 000000000000000f GLIBC_2.2.5 __dcgettext
000000000002dc80 w DF .text 000000000000000a GLIBC_2.2.5 dgettext
000000000002dc80 g DF .text 000000000000000a GLIBC_2.2.5 __dgettext
With attached patch situation is better.
q
sh$ autoreconf
sh$ CFLAGS="-Werror" ./configure
sh$ grep gt_cv_func_gnugettext config.log
gt_cv_func_gnugettext1_libc=yes
LS
8 years, 5 months
[PATCHES]: Add a sketch of Samba AD DC tests
by Nikolai Kondrashov
Hi everyone,
I've worked on Samba integration tests for a while and here is where I got
thus far. I'll need to resume my work on Session Recording [1] for now and
will be happy if someone took the Samba work over. If not I'll return to it
some time in the future.
The attached patches add very rudimentary Samba AD DC instance setup and
teardown, and a very basic test, plus the requisite changes. They require
Samba built with AD DC support, which is missing from RHEL/Fedora repos, but
can conveniently be acquired from Lukas's COPR repo (Thanks, Lukas!):
https://rhcopr-devel.lab.eng.brq.redhat.com/coprs/lslebodn/samba4/
The patches were confirmed working on Fedora 22 and Debian Testing. The latter
had resolv_wrapper installed manually, since it's not in Debian repos yet.
Among the things we still have to do are:
* Make Samba packages with AD DC support available for developers on
Fedora/RHEL. Add instructions for getting them to contrib/ci/README.md and
maybe somewhere else as well, if that's different from the already existing
COPR repo.
* Add support for disabling SSSD netlink use, perhaps with an environment
variable which can then be set in src/tests/intg/Makefile.am.
See https://fedorahosted.org/sssd/ticket/2860
* Deliver resolv_wrapper to Debian package repos.
* Write the actual tests.
Thanks everyone who helped me get this far!
Hope we get this working and merged eventually :)
Nick
[1] http://spbnick.github.io/2015/10/26/open-source-session-recording.html
8 years, 5 months