[PATCH] LDAP: Try all attributes when saving an entry
by Jakub Hrozek
Hi,
this bug was reported on #sssd by a user. He was running some flavor of
IBM Tivoli where the entries only had an "ID", not separate "UID" and
"GID". But due to a bug in sssd he couldn't use the same value for both,
this configuration:
ldap_user_uid_number = idAttribute
ldap_user_gid_number = idAttribute
only saved the ID into UID and left GID empty. It appears we have a long
standing bug in sdap_parse where we only consider first match. If this
patch is accepted, I would also like to refactor sdap_parse in master
because currently it is a 250-lines long function with multiple
branches..
9 years, 9 months
[PATCH] UTIL: Fix access out of bound in parse_args
by Lukas Slebodnik
ehlo,
While parsing string with multiple whitespaces, it may happen variable i is
zero and we want to test end of argument "tmp[i-1] != '\0'". Side effect of
this bug is duplicite string output array.
Input string: "foo b"
Expected output: { "foo", "a", NULL }
Output: { "foo", "foo", "a", NULL }
This patch uses inverted logic. Instead of testing whether to read next char or
skip multiple whitespaces, we will test whether we have new argument which
should be stored in output array.
How to test?
libtool --mode=execute valgrind ./util-tests
Running suite(s): util
==17839== Invalid read of size 1
==17839== at 0x4E60329: parse_args (util.c:208)
==17839== by 0x403A04: test_parse_args (util-tests.c:166)
==17839== by 0x4C2F139: tcase_run_tfun_nofork.isra.11 (check_run.c:327)
==17839== by 0x4C2F3C5: srunner_run (check_run.c:187)
==17839== by 0x4057ED: main (util-tests.c:1090)
==17839== Address 0x62f709f is 1 bytes before a block of size 7 alloc'd
==17839== at 0x4A0645D: malloc (vg_replace_malloc.c:291)
==17839== by 0x4E6020E: parse_args (util.c:149)
==17839== by 0x403A04: test_parse_args (util-tests.c:166)
==17839== by 0x4C2F139: tcase_run_tfun_nofork.isra.11 (check_run.c:327)
==17839== by 0x4C2F3C5: srunner_run (check_run.c:187)
==17839== by 0x4057ED: main (util-tests.c:1090)
==17839==
This problem was also reported by clang static analysers.
We thought it was false positive. Unfortunately, it wasn't.
LS
9 years, 9 months
[PATCH][ding-libs] SPEC: Use correct soname for packages lib{collection, ini_config}
by Lukas Slebodnik
ehlo,
There are RPM build errors with ding-libs master. It is my fault.
RPM build errors:
File not found: /BUILDROOT/ding-libs-0.4.0/usr/lib/libcollection.so.3
File not found: /BUILDROOT/ding-libs-0.4.0/usr/lib/libcollection.so.3.0.0
File not found: /BUILDROOT/ding-libs-0.4.0/usr/lib/libini_config.so.4
File not found: /BUILDROOT/ding-libs-0.4.0/usr/lib/libini_config.so.4.0.0
Patch is attached.
LS
9 years, 9 months
[PATCH 2/3] SPEC: Do not include compiled files into package libdhash-devel
by Lukas Slebodnik
ehlo,
Devel package should be platform independent and should not contain
compiled files.
/usr/share/doc/libdhash-devel/examples/.deps
/usr/share/doc/libdhash-devel/examples/.deps/.dirstamp
/usr/share/doc/libdhash-devel/examples/.dirstamp
/usr/share/doc/libdhash-devel/examples/.deps/.dirstamp
/usr/share/doc/libdhash-devel/examples/dhash_example.o
/usr/share/doc/libdhash-devel/examples/dhash_test.o
Simple patch is attached.
LS
9 years, 9 months
Closing Ticket #2045
by Michal Židek
Hi,
this ticket: https://fedorahosted.org/sssd/ticket/2045
(Create a test that corrupts the memcache)
is no longer valid. We intended to create this
test to figure out what is wrong with the memcache
when it randomly segfaulted in the past and we
could not reproduce it.
But the segfaults were later fixed by Lukas's patches
and so the investigation is no longer needed (Lukas
was actually able to reproduce it with a stress test).
If nobody is against it I will close the ticket later
today.
Michal
9 years, 9 months