while working on https://fedorahosted.org/sssd/ticket/2102 I noticed a
few minor problems regarding netgroups.
First check returned value then it is safe to access results.
It is my opinion that function lookup_netgr_step is too long and can be
safely (with minimum of changes) divided into 2 separate functions.
Pavel Brezina asked me to solve memory leak in lookup_netgr_step.
Fixes two code style issues.
Thank for review!
A user reported problem with the sss_obfuscate script on sssd-users mailing
list. The problem was that default version of python was not python 2.x.
We have a ticket fot python 3 support https://fedorahosted.org/sssd/ticket/2017
Meanwhile, we should have python2 in shebang.
Simple patch is attached.
I found this wrong return value. I've checked the other recent posting
and didn't found a patch for this. If someone already send a patch for
this please point me to the right thread so that I can ack it.
We defined macro _XOPEN_SOURCE before time.h, because we need function strptime
The problem is with undef after including header time.h
The macro _XOPEN_SOURCE can be defined on some platforms
and undef can cause problems.
We detect all necessary feature macros in configure script
using AC_USE_SYSTEM_EXTENSIONS or AC_GNU_SOURCE.
It is better to include header file config.h
instead of defining macro _XOPEN_SOURCE