IFP: Implement methods to get and list domain objects
by Jakub Hrozek
Hi,
the attaches two patches implement DBus methods to retrieve SSSD domains
using the system bus as well as two example getters that leverage the
infrastructure to Get and GetAll the object properties.
Pavel, I know you have a large patchset in a private tree that
implements the other getters and moves the domain methods into a
separate file. I'm fine with merging your and mine patches, I just
wanted to get the ball rolling on the list. Feel free to reply with your
patchset.
9 years, 11 months
Make return codes of basic sysdb operations consistent
by Pavel Reichl
Hello,
I recently started working on ticket #1991.
https://fedorahosted.org/sssd/ticket/1991
"The return codes of various sysdb operations differ. Some search
operations would return ENOENT if they don't find a matching object some
would return EOK but an empty result list."
I think that the core of the problem is the expectation that ldb_search
returns LDB_ERR_NO_SUCH_OBJECT in case no results were found. But it
instead returns LDB_SUCCESS and sets result->count to 0.
I think it would be best for sysdb functions in case that no results
were found to return both ENOENT value and 'properly' empty list.
Thanks for opinions.
Pavel Reichl
9 years, 11 months
[PATCH] sss_autofs: Check return value of autofs make request
by Lukas Slebodnik
ehlo,
There were two different crashed in BZ1079237 [1]
The first one was in sssd_be (it was fixed commit e18d5c703c529f99bd375da887d9)
and the second one in sss autofs plugin. (client code)
Attached patches should fix the sond crash.
How to reproduce?
a) -- revert commit e18d5c703c529f99bd375da887d9
-- have more then one attribute "automountKey" in LDAP entry
-- call automount -m
b) #can be reproduced with current master
-- use small value of option timeout in autofs section (can be default)
-- attach gdb to the autof responder
-- add breakpoint to the function b setautomntent_send and continue
-- call automount -m
-- gdb in autofs responder will interrupt execution (do nothing)
-- automount will crash after few seconds (60-120)
LS
[1] https://bugzilla.redhat.com/show_bug.cgi?id=1079237
9 years, 11 months
[PATCH] Two small unit test patches
by Jakub Hrozek
Hi,
I was working on reusing parts of the sbus test suite to test the IFP
responder and while that work is not finished yet, these two simple
patches can be applied separately.
9 years, 11 months
[PATCH] Implement org.freedesktop.DBus.Properties.GetAll for primitive types
by Jakub Hrozek
Hi,
the attached patches implement the
org.freedesktop.DBus.Properties.GetAll method for retrieving primitive
types and their arrays.
The patchset build on the previous set (currently still on review) that
implements the .Get method. The GetAll handler simply walks through the
existing getters and retrieves the results, storing them in a single
variant.
The patches include a unit test that tests all currently supported
combinations of primitive types and array of primitive types.
9 years, 11 months
[PATCH] TEST: fix warning in sbus_codegen_tests
by Pavel Reichl
Hello,
I found this warning,
../src/tests/sbus_codegen_tests.c: In function ‘test_vtable’:
../src/tests/sbus_codegen_tests.c:182:5: error: missing initializer for field ‘com_planetexpress_Ship_get_Color’ of ‘struct com_planetexpress_Ship’ [-Werror=missing-field-initializers]
Attached patch fixes the issue, but please feel free to propose more useful fix.
Thanks,
PR
9 years, 11 months
[PATCH] UTIL: Include netinet/in.h for ip adress macros
by Lukas Slebodnik
ehlo,
The manual page in.h (man in.h) says:
The <netinet/in.h> header shall define the in6_addr structure that con‐
tains at least the following member:
uint8_t s6_addr[16]
The <netinet/in.h> header shall define the following macros that test
for special IPv6 addresses. Each macro is of type int and takes a sin‐
gle argument of type const struct in6_addr *:
IN6_IS_ADDR_LINKLOCAL: Unicast link-local address.
IN6_IS_ADDR_LOOPBACK: Loopback address.
IN6_IS_ADDR_MULTICAST: Multicast address.
The header file netinet/in.h> was not included directly in src/util/util.c
and it caused few problems.
LS
9 years, 11 months