while working on https://fedorahosted.org/sssd/ticket/2102 I noticed a
few minor problems regarding netgroups.
First check returned value then it is safe to access results.
It is my opinion that function lookup_netgr_step is too long and can be
safely (with minimum of changes) divided into 2 separate functions.
Pavel Brezina asked me to solve memory leak in lookup_netgr_step.
Fixes two code style issues.
Thank for review!
We defined macro _XOPEN_SOURCE before time.h, because we need function strptime
The problem is with undef after including header time.h
The macro _XOPEN_SOURCE can be defined on some platforms
and undef can cause problems.
We detect all necessary feature macros in configure script
using AC_USE_SYSTEM_EXTENSIONS or AC_GNU_SOURCE.
It is better to include header file config.h
instead of defining macro _XOPEN_SOURCE
the attached patch fixes https://fedorahosted.org/sssd/ticket/2291
To test, log in as an sssd user and run:
Before the patch, the sbus test would fail with a strange error message
Could not get password database information for UID of current
process: User "???" unknown or no memory to allocate password entry
The patch disables the sbus_tests and sbus_codegen tests when running
distcheck. The tests are still built and ran as appropriate when running
when testing the master branch distribution prior to releasing 1.12
beta1 I realized the sssd-ifp man page was not listed in the po4a.cfg.
This was breaking make update-po.
To reproduce, simply run:
autoreconf -if && ./configure && make update-po && make distcheck