please see attached patches.
patch #1 - disable midpoint refresh for netgroups if ptask refresh is
The rest of patches solves some minor problems that occurred while I
was working on 1st patch:
patch #2 - fixes sysdb_getnetgr to return ENOENT as is as is expected in
patch #3 - first check return value then access output parameter
patch #4 - some minor code style improvements, some lines over 80
columns, IMO strange indentation of string constants - feel free to
Here's the next patchset for refactoring the DBus support in sssd.
This patch set reorganizes how handlers handle requests. At center stage
is 'struct sbus_request' which is a talloc context valid for the
duration of the DBus requests.
There are also various sbus_request_xxx_finish() methods which reply to
the caller and cleanup the request.
The next set of patches (after this one) have the support for
automatically invoking type-safe handlers and build off of this
patchset. That said, even on this own, these changes result in lots of
cleanup and some code savings.
Patch 0001 fixes portability bugs.
I've added some test cases for the sbus code that has changed.
However since there are no automatic tests for much of the monitor and
data provider methods, I would recommend lots of smoke testing for these
If you prefer to access this as a branch, see:
To see the later work that builds off of this:
attached patch addresses ticket #2193
I have just a question about refarray/libref_array.sym
There is extern function ref_array_debug, which is not defined
in public header file (not exposed in public API), but it is used in ref_array
unit tests. It needs to be in global section because linker with fail to find
symbol. Should I add any comment to the file libref_array.sym or does anyone
I was working on a reusable request to split a raw name into
(name,domain) component instead of copying sss_parse_name_for_domains
along with subdomain refresh all around the responder code and noticed
that the sss_parse_name_for_domains() code is really complex and hard to
follow. To understand the code better and validate my assumptions, I
wrote a unit test and did a couple of very small fixes in the
sss_parse_name_for_domains function itself. Kindly see the commit
message for explanation of the small fixes.