please see attached patch.
The ticket addressed by this patch may not be as important as it used to
be because 'check_parent_stat' now logs detailed information about
sss_parse_name currently SIGSEGVs if any of output parameters (domain,
name) is a NULL. I think it may be useful to support passing NULL
arguments as not always both pieces of information are needed.
Please see attached patch.
Attached is a patch with the additional test functions for getpwuid*
functions. I think I did not get the flow of the data in program properly.
That is why getting similar errors.
Please have a look into the patch and let me know how to improve upon it.
On (13/02/14 03:12), Alexey Shabalin wrote:
>2014-02-12 23:50 GMT+04:00 Lukas Slebodnik <lslebodn(a)redhat.com>:
>> We needn't complicate this patch anymore. I fine with this version.
>> One more time.
>> Alexey Shabalin, thank you very much for the patch. If you have any other
>> sssd or ding-libs please send patches as soon as possible :-)
>Thank you very much.
I have few questions about packaging sssd in ALT Linux.
According to spec file
There is explicit build requirements for nscd.
Why do you need it?
Build requires for cmocka is commented out. (probably libcmocka-devel is not
available on your distribution, but it would be great if sssd was tested with
Why did you disable find_uit test?
I didn't have any problem with this test.
(tested version altlinux-7.0.0-centaurus-x86_64-ru-live-cd.iso)
thanks to Alexey Shabalin (ALT Linux Team), following patch makes sure
SSSD will compile against MIT Kerberos with headers installed in a
subdirectory of /usr/include (/usr/include/krb5 in ALT Linux).
/ Alexander Bokovoy
We had in source code following pattern #elif HAVE_<name>
It worked because undefined identifier(in some cases) was evaluated to 0.
But we do not care about value of HAVE_SOMETHING. We just need to know
whether identifier was defined.
There is not equivalent to #ifdef (short for of #if definded)
We need to use long form: #elif defined HAVE_<name>
It causes also compiler warning with enabled compiler flag -Wundef.
When working on the SELinux code lately, I found out that all the
functions from sss_selinux.c are consumed by ipa_selinux.c only. I don't
think it makes sense to have a sss_selinux.c module in the util/ tree,
so I simply merged the functions into ipa_selinux.