Re: [SSSD] [PATCH] use proper Kerberos CFLAGS
by Lukas Slebodnik
On (13/02/14 03:12), Alexey Shabalin wrote:
>2014-02-12 23:50 GMT+04:00 Lukas Slebodnik <lslebodn(a)redhat.com>:
>
>> We needn't complicate this patch anymore. I fine with this version.
>>
>> One more time.
>> ACK
>>
>> Alexey Shabalin, thank you very much for the patch. If you have any other
>> with
>> sssd or ding-libs please send patches as soon as possible :-)
>>
>> LS
>>
>
>
>Thank you very much.
>
>
>--
>Alexey Shabalin
I have few questions about packaging sssd in ALT Linux.
According to spec file
http://git.altlinux.org/people/shaba/packages/?p=sssd.git;a=blob;f=sssd.s...
There is explicit build requirements for nscd.
Why do you need it?
Build requires for cmocka is commented out. (probably libcmocka-devel is not
available on your distribution, but it would be great if sssd was tested with
libcmocka.
Why did you disable find_uit test?
http://git.altlinux.org/people/shaba/packages/?p=sssd.git;a=blobdiff;f=Ma...
I didn't have any problem with this test.
(tested version altlinux-7.0.0-centaurus-x86_64-ru-live-cd.iso)
LS
10 years, 1 month
[PATCH] use proper Kerberos CFLAGS
by Alexander Bokovoy
Hi,
thanks to Alexey Shabalin (ALT Linux Team), following patch makes sure
SSSD will compile against MIT Kerberos with headers installed in a
subdirectory of /usr/include (/usr/include/krb5 in ALT Linux).
Please apply.
--
/ Alexander Bokovoy
10 years, 1 month
[PATCH] Fix copying default dp_option values
by Jakub Hrozek
Hi,
The attached two patches are related to:
https://fedorahosted.org/sssd/ticket/2257
The first patch is included pretty much for completeness, as I noted
during development of the unit test, the blob type didn't handle any
default value.
The second patch directly addresses #2257. The previous code didn't
handle copying options well if the option was set to zero, because the
code followed logic like:
if (oldval) {
newval = oldval;
else {
newval = defval;
}
The patch implements Sumit's idea to provide a separate function for
copying default values and amend the generic copy function to only
create a copy using the current values.
10 years, 1 month
[PATCH] TESTS: Link libsss_test_common with tevent
by Lukas Slebodnik
ehlo,
Static library libsss_test_common calls tevent functions directly (in module
common_tev.c), but it was not linked with tevent library.
Compilation will fail if sssd is linked with "-Wl,--as-needed"
CCLD test_utils
/usr/bin/ld: ./.libs/libsss_test_common.a(common_tev.o): undefined reference to symbol 'tevent_context_init@(a)TEVENT_0.9.9'
/usr/bin/ld: note: 'tevent_context_init@(a)TEVENT_0.9.9' is defined in DSO /usr/lib/gcc/x86_64-redhat-linux/4.8.2/../../../../lib64/libtevent.so so try adding it to the linker command line
/usr/lib/gcc/x86_64-redhat-linux/4.8.2/../../../../lib64/libtevent.so: could not read symbols: Invalid operation
clang: error: linker command failed with exit code 1 (use -v to see invocation)
nm ./libsss_test_common.a | grep tevent
U tevent_context_init
U _tevent_loop_once
U _tevent_req_create
U _tevent_req_done
U _tevent_req_error
U tevent_req_is_error
U tevent_req_post
Simple patch is attached.
LS
10 years, 1 month
[Patch] Cmocka unit test for negcache.c module
by Pallavi Jha
Hi,
I have attached the test patch for negcache.c module along with the mail.
I could not write test for the last function sss_ncache_prepopulate(). I
have doubt regarding the initialization of the arguments to be passed to
sss_ncache_prepopulate(). Please review the patch.
Thanks,
Pallavi
10 years, 1 month
[PATCH] config API: prepend source dir search path for tests
by Sumit Bose
Hi,
I came across this while testing some changes to the config API.
Additionally I realized that the config API opens every file in
schemaplugindir (.../sssd.api.d) including hidden ones starting with a
'.'. This might lead to test failures if backup copies or swap file of
running editors are read. Since this is primarily an issue on developers
systems I wonder if this should be fixed or not?
bye,
Sumit
10 years, 1 month
[PATCH] config API: read only specific files from schemaplugindir
by Sumit Bose
Hi,
as mentioned earlier on this list the python config API currently reads
any file from /usr/share/sssd/sssd.api.d which might result in all kinds
of strange errors if e.g. editor swap or backup files can be found in
this directory.
With this patch only files matching the pattern '^sssd-.*\.conf$' are
read from this directory.
bye,
Sumit
10 years, 1 month
[PATCH] SUDO: AD provider
by Sumit Bose
Hi,
this patch provides the AD sudo provider and is "inspired" by Lukas'
"SUDO: IPA provider" patch.
I do not have an AD setup with sudo rules. It would be nice if someone
with such setup can run some basic test otherwise I can/have to do some
additional testing.
Patches for master and 1.11 are attached.
bye,
Sumit
10 years, 1 month
[PATCH] DOC: Fix names of arguments in doxygen comments
by Lukas Slebodnik
ehlo,
I found few warning generated by doxygen in the ouput from building rpms.
For example:
./src/lib/idmap/sss_idmap.h:544: warning: argument 'smb_sid' of command @param
is not found in the argument list of
sss_idmap_free_bin_sid(struct sss_idmap_ctx *ctx, uint8_t *bin_sid)
./src/lib/idmap/sss_idmap.h:544: warning: The following parameters of
sss_idmap_free_bin_sid(struct sss_idmap_ctx *ctx, uint8_t *bin_sid)
are not documented: parameter 'bin_sid'
Patch is attached.
LS
10 years, 1 month
[PATCH] libsss_idmap: bump version-info
by Sumit Bose
Hi,
this patch bumps the version number of libsss_idmap and should be aplied
to master and 1-11 to keep them in sync.
Currently the version is libsss_idmap.so.0.3.0 and after the patch it
should be libsss_idmap.so.0.4.0.
The doc changes from 3b35ff47651e4893ce537a273466766b962362da are
currently missing in 1.11. I'm not sure if the aptch should be applied
to 1.11? On one hand only typos in the docs are fixed on the other hand
only typos in the docs are fixed :-)
bye,
Sumit
10 years, 1 month