SSSD patch
by Carlos Munoz
Hi,
I am currently working on migrating SSSD translations to Zanata and am
submitting the attached patch per the instructions on the project's wiki.
The patch includes the addition of a Zanata client configuration file so
translations can be pushed / pulled from the Zanata server. the project
has already been created in Zanata
(https://fedora.zanata.org/project/view/sssd)
Let me know if you have any questions.
Regards,
--
Carlos A. Munoz
Software Engineering Supervisor
Engineering - Internationalization
Red Hat
8 years, 5 months
[PATCH] monitor: Service restart fixes
by Stephen Gallagher
There are actually two bugs here:
1) When either the kill(SIGTERM) or kill(SIGKILL) commands returned
failure (for any reason), we would talloc_free(svc) which removed it
from being eligible for restart, resulting in the service never
starting again without an SSSD service restart.
2) There is a fairly wide race condition where it's possible for a
SIGKILL timer to "catch up" to the child exit handler between us
noticing the termination and actually restarting it. The race
happens because we re-enter the mainloop and add a restart
timeout to avoid a quick failure if we keep restarting due to a
transitory issue (the mt_svc object, and therefore the SIGKILL
timer, were never freed until we got to the actual service
restart).
We can minimize this race by recording the timer_event for the
SIGKILL timeout in the mt_svc object. This way, if the process
exits via SIGTERM, we will immediately remove the timer for the
SIGKILL.
This patch also removes the incorrect talloc_free(svc) calls on the
kill() failures and replaces them with an attempt to just start up
the service again and hope for the best.
Resolves:
https://fedorahosted.org/sssd/ticket/2525
8 years, 5 months
Data dir and cwrap tests
by Nikolai Kondrashov
Hi everyone,
In order to run integration tests as non-root we would need to have all data
directories and files to reside in a user-writeable (temporary) directory.
However, it seems that various sssd data directory and file locations are
spread over the code as preprocessor macros, resulting in static strings. See
the output of this command executed in a build dir:
find -type f -perm -111 -name '*.so*' -or -name 'lt-*' |
xargs strings -f | grep var/lib/sss
Making this changeable at runtime doesn't seem to be practical. Replacing all
these in binaries after build somehow is not easy to do reliably. So, are we
left with forgoing the idea of running cwrap tests under "make check" and
relying on a special-prefix build in "contrib/ci/run", or could there be some
other ways?
It could be "fakechroot", but it is not in RHEL repos, it seems, and I'm not
sure how well it will work and how easy it will be to setup and maintain the
required directory tree and files.
Thank you.
Nick
8 years, 5 months
[PATCH] ldap: use case insensitive check
by Arjun Sreedharan
Signed-off-by: Arjun Sreedharan <arjun024(a)gmail.com>
---
src/providers/ldap/ldap_id_cleanup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/providers/ldap/ldap_id_cleanup.c b/src/providers/ldap/ldap_id_cleanup.c
index f78d4b4..88e487b 100644
--- a/src/providers/ldap/ldap_id_cleanup.c
+++ b/src/providers/ldap/ldap_id_cleanup.c
@@ -361,7 +361,7 @@ static int cleanup_groups(TALLOC_CTX *memctx,
}
posix = ldb_msg_find_attr_as_string(msgs[i], SYSDB_POSIX, NULL);
- if (!posix || strcmp(posix, "TRUE") == 0) {
+ if (!posix || strcasecmp(posix, "TRUE") == 0) {
/* Search for users that are members of this group, or
* that have this group as their primary GID.
* Include subdomain users as well.
--
1.7.11.7
8 years, 5 months
cwrap test roadblock
by Nikolai Kondrashov
Hi everyone,
While trying to arrange running sssd under cwrap in "make check" I came upon
this roadblock:
There doesn't seem to be a way to make libnsss_sss use server sockets in
non-default location at runtime, only at build time. And it seems that doing
it at runtime would be a security issue.
That means that we can't include tests involving libnss_sss into "make check",
as that is not guaranteed to be invoked on a build with a special location
where the current user can write to.
This leaves us with being able to run these tests under CI only, which can
arrange for special configure options and thus locations.
Could there be another way? Am I missing something?
Thanks a lot for any suggestions!
Nick
8 years, 5 months