[PATCH] Prevent using uninitialized "group_name" in done section.
by Lukas Slebodnik
ehlo,
Commit bfd59d1a2d0d45125e5164ef12c425690d519f61 introduced new Coverity issue.
In case of failure, variable group_name can be used uninitialized in DEBUG
macro.
# DEBUG(SSSDBG_MINOR_FAILURE,
# ("Failed to save group [%s]: [%s]\n",
#- name ? name : "Unknown",
#+ group_name ? group_name : "Unknown",
^^^^^^^^^^
uninit_use: Using uninitialized value "group_name".
# strerror(ret)));
Before this commit, variable name was used in the same place and
variable name was initialized to NULL.
I suppose that we should run coverity scan in the review proces
(either automatically patchwork??? or manually)
Patch is attached.
LS
10 years, 9 months
Announcing SSSD 1.11 beta 2
by Jakub Hrozek
=== SSSD 1.11 beta 2 ===
The SSSD team is proud to announce the second beta release of version 1.11
of the System Security Services Daemon.
This pre-release does not bring substantial changes visible to the end-user. It
is intended to be part of the development of FreeIPA 3.3 and its focus of
supporting legacy (non-SSSD) clients in a setup where IPA server established
a trust relationship with an Active Directory clients.
A Fedora Test Day aimed at exercising the new features is planned for July
25th. See the Test Day page for more information:
https://fedoraproject.org/wiki/Test_Day:2013-07-25_AD_trusts_with_POSIX_a...
As always, the source is available from https://fedorahosted.org/sssd.
== Feedback ==
Please provide comments, bugs and other feedback via the sssd-devel or
sssd-users mailing lists:
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
https://lists.fedorahosted.org/mailman/listinfo/sssd-users
== Highlights ==
* Includes several fixes related to setup where the SSSD is running on
IPA client in a special "server mode".
* The default DNS timeouts have been tweaked in order to allow the c-ares
resolver to cycle through all available name servers
* The pysss module now contains a new method `getgroupslist` that provides
a Python interface to the POSIX `getgroupslist(3)` call
* The sss_debuglevel tool is now able to change debug level of all
responders, including PAC or autofs
== Tickets Fixed ==
https://fedorahosted.org/sssd/ticket/1965
man: document that the default access provider in AD provider is "permit"
https://fedorahosted.org/sssd/ticket/1988
[RFE] sss_cache has no option to clear all cached entries of all types
https://fedorahosted.org/sssd/ticket/1997
When resolving a SID, search for groups first, then users
https://fedorahosted.org/sssd/ticket/1998
sssd-ad man page states that ad_server can be an IP address even though SSSD doesn't support that
https://fedorahosted.org/sssd/ticket/2005
SSSD filter out ldap user/group if uid/gid is zero
https://fedorahosted.org/sssd/ticket/2009
Disallow or warn if full_name_format is set to a non-default value when IPA server mode is on
https://fedorahosted.org/sssd/ticket/2023
AD provider in server mode follows referrals
https://fedorahosted.org/sssd/ticket/2025
pysss module linking is broken
== Documentation Changes ==
* The dns_resolver_timeout option default value was changed from 5
to 6 seconds. At the same time, the timeout that controls how long the
internal resolver communicates with a single DNS server was changed to
2 seconds. This change would allow the resolver to cycle through up to 3
nameservers until the `dns_resolver_timeout` fires.
* the sss_cache utility gained a new option -E. This option is a
shortcut to tell sss_cache to invalidate all entries in the cache. Please
note that invalidating sudo rules is still not implemented as it requires
cooperation with the back end as well.
== Detailed Changelog ==
This changelog does not include commits already released in 1.10.1
release. To see all changes since 1.11 beta2, run:
$ git shortlog sssd-1_11_0_beta1..sssd-1_11_0_beta2
from a directory that contains the SSSD git checkout.
Alexander Bokovoy (3):
* build: fix dependencies for pysss module
* pysss: add pysss.getgrouplist(username)
* pysss: prevent crashing when group is unresolvable
Jakub Hrozek (13):
* Bumping the version for the 1.11 beta2 release
* LDAP: When resolving a SID, search for groups first, then users
* MAN: clarify the default access provider for AD
* MAN: IP addresss does not work when used for ad_server
* MAN: Clarify the min_id/max_id limits further
* Remove unused be_ctx->sigchld_ctx
* IPA: warn if full_name_format is customized in server mode
* AD: Set the bool value same as default value in opts
* Fix the default FQDN format
* SUDO: realloc with sizeof(uint32_t) when adding uint32_t
* KRB5: Do not send PAC in server mode
* LDAP: Use domain-specific name where appropriate
* Updating translations for the 1.11 beta2 release
Lukas Slebodnik (11):
* BUILD: Use pkg-config to detect cmocka
* Use conditional build for retrieving ccache.
* Remove unused function parameter
* Fix clang format string warning.
* Use functionm ldb_dn_get_linearized to format struct ldb_dn
* Add mising argument required by format string
* Remove unused memory context from function unpack_authtok
* Fix warnings: uninitialized variable
* Fix autotols warnings: macro xyz not found in library
* Fix possible dereference of a NULL pointer.
* Every time release allocated memory in function py_sss_getgrouplist
Michal Zidek (5):
* sss_cache: Add option to invalidate all entries
* Missing space in debug message
* Remove unused constant.
* Set default DNS resolution timeout to 6 seconds.
* Lower timeout to contact DNS server
Ondrej Kos (1):
* TOOLS: Update all services with sss_debuglevel
Pavel Březina (1):
* remove unused variable
10 years, 9 months
[PATCH] LDAP: Use domain-specific name where appropriate
by Jakub Hrozek
The subdomain users user FQDN in their name attribute. However, handling
of whether to use FQDN in the LDAP code was not really good. This patch
introduces a utility function and converts code that was relying on
user/group names matching to this utility function.
This is a temporary fix until we can refactor the sysdb API in #2011.
Alexander, this patch fixed the username issues for me. I still see one
more problem -- on the first ID lookup, the user is reported as a member
of "Domain Users", but not on the subsequent lookups. This is unrelated
problem I'm looking into, but the attached patch is still correct.
10 years, 9 months
[PATCH] add pysss.getgrouplist(username)
by Alexander Bokovoy
Hi!
Apparently, getgrouplist(3) call is not available in Python older than
Python 3.3. So I agreed with Jakub to have it bound to pysss Python
module. We need this call to obtain list of groups trusted domain user
belongs to for HBAC testing in FreeIPA.
Additionally, I've fixed bug with linking of pysss. This patch is
relevant to 1.10 as well, while the first one is needed in sssd 1.11.
--
/ Alexander Bokovoy
10 years, 9 months