As Dmitri noted in a thread on sssd-users, we did an incompatible change
in how we handle lines beginning with whitespace. Since the change is
breaking existing configurations, we should revert the change.
There is a separate ticket to consider the line wrapping functionality:
scan-build found a warning.
src/providers/krb5/krb5_child.c:1988:9: error: ‘offline’ may be used
uninitialized in this function [-Werror=maybe-uninitialized]
ret = k5c_setup(kr, offline);
gcc also reports this warning with enabled optimization >= "-O2".
It seems to me really weird, because compilator assumes that function
sss_atomic_read_s return value -1 and errno==0.
I tried to modify function sss_atomic_read_s, but I could not fix this warning.
Another possible solution is to initialize variable "offline" to some default
I appreciate any comment.
Patch is attached.
I came across an interesting behavior that is IMO worth sharing with
It turns out that fmemopen() fails with error 22 EINVAL if the buffer
passed in is of length 0.
Imagine situation: I have a file in the directory of 0 length.
I open it with fopen() or with open() and then fdopen() in "r" mode and
I can read it with getline(). Of cause the first read will return EOF
and I will be done. But if I open file with open() in binary mode, and
mirror it into a buffer and the file is of length 0 then the buffer will
be of length 0 too but attemt to use fmemopen() would fail.
So mirroring in becomes non transparent operation you have to special
case the situation when original file in NULL.
So question is what should I do with it? File a bug or just ask to
document it? Man page does not say anything about it.
Sr. Engineering Manager for IdM portfolio
Red Hat Inc.
Looking to carve out IT costs?
-----BEGIN PGP SIGNED MESSAGE-----
Originally, we planned to deprecate the decimal values for the debug
levels, but that has proven to be too difficult for most users to
understand. Instead, we will document both the simple decimal and
complex bitmask values and recommend the use of the decimal values.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.14 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
-----END PGP SIGNATURE-----
I've started to implement a plugin for the cifs-utils idmap interface.
Currently it lives in an own repository and can be build outside the sssd
tree, thanks to the public sssd libraries libsss_idmap.so and
Still missing is the mapping of Samba's Unix SIDs and some well known SIDs
(more info in cifs_idmap_sss.c)
Are you intrested in reviewing it and/or have it included in the sssd git
tree or somehow else as a sssd project?
Attached an untested possible alternative for #2071
The other option is the last patch of my previous patchset in the thread
named: "[SSSD] [PATCHES] Simplify credential krb5 cache manipulation".
Let's discuss if any of these approaches is ok, or if a third way needs
to be found.
Simo Sorce * Red Hat, Inc * New York