[PATCH] TESTS: Fix coverity issues 13126, 13127
by Ondrej Kos
patch is attached
--
Ondrej Kos
Associate Software Engineer
Identity Management
Red Hat Czech
phone: +420-532-294-558
cell: +420-736-417-909
ext: 82-62558
loc: 1013 Brno 1 office
irc: okos @ #brno
11 years, 2 months
[PATCH] link sss_ssh_knownhostsproxy with -lpthread
by Timo Aaltonen
sssd fails to build on current ubuntu devel series possibly due to some
updated build-dependency which used to be overlinked so that
sss_ssh_knownhostsproxy no longer gets -lpthread in it's LDFLAGS.
11 years, 2 months
[PATCH] Fix pam responder handling of coalesced requests
by Simo Sorce
In our responders we have a feature that allows to avoid dispatching
multiple identical requests at the same time.
This is done by queing additional identical requests in a special hash
table and then replying to all clients at the same time when a response
is received.
When the connection to a provider breaks all these waiting requests need
to be cleaned out and the has table emptied.
This was not happening in sssd_pam, so if a connection to the provider
was lost client request would pile up and never be replied again.
The attached patch fixes this issue. Tested using kill -STOP of the
sssd_be process and trying to authenticate via the gnome screensaver.
Fixes: https://fedorahosted.org/sssd/ticket/1655
--
Simo Sorce * Red Hat, Inc * New York
11 years, 2 months
[PATCH] Do not grow sssd_nss memory footprint
by Jakub Hrozek
Hi,
the attached patch might seem simple, but it touches a delicate and
low-level part of the SSSD, so I'd like to request a detailed review.
I was notified by Bruce Aiesi of the Red Hat QE team that the sssd_nss
process grew its memory footprint when stress-tested by logging in many
users in parallel. I ran a couple of tests and then found out that the
responder context grew because we never freed the internal Data Provider
request. Attached is a patch that simple frees the "side request" after
all the callbacks have been invoked.
I didn't see the memory growth anymore during my testing and I didn't
see any other issues, either during my tests or with valgrind.
I hope I didn't miss any detail and the patch is OK.
11 years, 2 months
[PATCH] Do not always return PAM_SYSTEM_ERR when offline krb5 fails
by Jakub Hrozek
I noticed that if offline auth failed for any reason including mistyped
password, we would always print System Error. This makes auditing the
logs hard as it sounds like an internal error occured.
I don't like the header with a single inline function myself, but I
didn't want to clutter util.h with that function either. And we don't
have any shared header for that purpose at the moment..suggestions are
welcome.
11 years, 2 months
[PATCH] Bump the version to 1.9.5, reset release in RPMs to 0
by Jakub Hrozek
Normally I just push version bumps when releasing a new version without
sending the patch, but this time I also need to fix packaging bug.
Intended for the sssd-1-9 branch only, the master branch had been fixed
when we branched off sssd-1-9.
11 years, 2 months