September 2009 - sssd-devel - Fedora mailing-lists

[PATCH] Collection improvements to copy functions
by Dmitri Pal 10 Sep '09

10 Sep '09

See patch comment. Also ticket #174 https://fedorahosted.org/sssd/ticket/174 regarding constants that might alert your attention. -- Thank you, Dmitri Pal Engineering Manager IPA project, Red Hat Inc. ------------------------------- Looking to carve out IT costs? www.redhat.com/carveoutcosts/

3 2

[PATCH] Fix proxy enumerations with newer tevent
by Simo Sorce 10 Sep '09

10 Sep '09

newer tevent versions (correctly) fail if loops are nested. fix the code to never nest loops. Simo. -- Simo Sorce * Red Hat, Inc * New York

4 6

[PATCH] fix DBusWatch handling
by Simo Sorce 10 Sep '09

10 Sep '09

After some playing around with Stephen patch and adding some debugging I finally understood how DBUS likes to deal with watches. We erroneously assumed that DBUS would add only one watch per FD. It doesn't, instead it always adds 2 watches. One to catch read events and one to catch write events. It then proceed to always keep one of the 2 disabled when the other is enabled, and it always toggles both when it needs to reverse access to the file descriptor. The following patch keeps track of sbus-watches/fd pairs and allocate both DBusWatches to the same structure. So far testing seem to confirm this approach works as expected. Simo. -- Simo Sorce * Red Hat, Inc * New York

3 3

[PATCHES] Handle invalid domain configuration better
by Stephen Gallagher 10 Sep '09

10 Sep '09

Patch 0001: Ensure that daemonization happens after reading in the configuration, so critical configuration errors repord "FAILED" during init script startup. Patch 0002: Ensure that the minId and maxId values are sensible (minId > maxId, neither < 0) -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts/

3 4

[PATCH] Update manpage with new enumerate syntax
by Stephen Gallagher 10 Sep '09

10 Sep '09

$SUBJECT -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts/

2 2

[PATCH] Add support for the EntryCacheNoWaitRefreshTimeout
by Stephen Gallagher 09 Sep '09

09 Sep '09

This timeout specifies the lifetime of a cache entry before it is updated out-of-band. When this timeout is hit, the request will still complete from cache, but the SSSD will also go and update the cached entry in the background to extend the life of the cache entry and reduce the wait time of a future request. Support for the EnumCacheNoWaitRefreshTimeout is still forthcoming, but I wanted to get a formal review on this portion. -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts/

2 9

[PATCH] COLLECTION Copy collection flat with concatenated names
by Dmitri Pal 09 Sep '09

09 Sep '09

See patch comment. This patch most likely will not apply cleanly without my previous ELAPI patches. So far it is 4 th pending patch. More to come. -- Thank you, Dmitri Pal Engineering Manager IPA project, Red Hat Inc. ------------------------------- Looking to carve out IT costs? www.redhat.com/carveoutcosts/

3 6

[PATCH] Cleanups for library linking
by Sumit Bose 09 Sep '09

09 Sep '09

Hi, I think the LDAP provider should link agains a LDAP library. So far it only worked, because sssd_be exports all symbols and links against libldb which links against libldap. bye, Sumit

3 2

[PATCH] more fixes for older libpcre versions
by Sumit Bose 09 Sep '09

09 Sep '09

Hi, older versions of libpcre only support the Python naming style, ?P<name>, for subpatterns. This patch changes our default pattern and adds some hints about this. bye, Sumit

3 2

[PATCH] ELAPI Laying foundation for the async processing
by Dmitri Pal 08 Sep '09

08 Sep '09

See patch subject and commit comment. This patch requires previous two patches I sent. -- Thank you, Dmitri Pal Engineering Manager IPA project, Red Hat Inc. ------------------------------- Looking to carve out IT costs? www.redhat.com/carveoutcosts/

2 5

[PATCH] Correcting issues
by Dmitri Pal 08 Sep '09

08 Sep '09

Hi, This patch corrects (hopefully last) set of issues found in the earlier patches during review. The ones that are not addressed yet are tracked via explicit tickets or via FIXME comments in the code. The whole stack of the pending patches is: * ELAPI sinks and providers * ELAPI Adding file provider and CSV format * ELAPI Laying foundation for the async processing * COLLECTION Copy collection flat with concatenated names * ELAPI Correcting issues -- Thank you, Dmitri Pal Engineering Manager IPA project, Red Hat Inc. ------------------------------- Looking to carve out IT costs? www.redhat.com/carveoutcosts/

2 2

[PATCH] ELAPI Adding file provider and CSV format
by Dmitri Pal 08 Sep '09

08 Sep '09

Hi, This patch is next significant chunk of code. See patch comments for the main description. It requires previous patch that has been reviewed but was not pushed yet. It addresses some of the suggestions risen during the review. I also added couple tickets: to eventually remove all the "Fixme" comments and to refactor places where I allocated context structs and initialize them. Checked with make check, valgrind and did in tree and parallel builds. All works, no leaks. Sorry that it is too big. I need to move on and there are many things that are still missing. I will start working on the next set of the functionality tomorrow mainly adding async processing. That would definitely affect some of the arguments passed all along so expect changes to many modules. -- Thank you, Dmitri Pal Engineering Manager IPA project, Red Hat Inc. ------------------------------- Looking to carve out IT costs? www.redhat.com/carveoutcosts/

4 12

[PATCH] ELAPI sinks and providers
by Dmitri Pal 08 Sep '09

08 Sep '09

Please see the patch comment. -- Thank you, Dmitri Pal Engineering Manager IPA project, Red Hat Inc. ------------------------------- Looking to carve out IT costs? www.redhat.com/carveoutcosts/

3 10

[PATCH] Split database file to one per domain
by Simo Sorce 08 Sep '09

08 Sep '09

Hello list. So far we have been using a single database file for all our caches as well as for the local domain. Initially I used a single database because I thought we could optimize some search queries when it came to enumerations. That didn't prove true and in effect we are doing always separate searches for different domains (in fact the patch was rather simple to write from this pov as no searches needed to be touched at all). Using a single database file for all domains is otherwise a disadvantage. >From a pure "security" point of view each backend has now it's own database and cannot "screw up" other domains data. Each domain access its backend separately so there is less contention when you want to start a transaction. The various files are clearly separated, so you can easily just delete all the ones named cache-NAME.ldb and not risk deleting the persistent data in sssd.ldb The patch includes also upgrade routines to automatically backup and convert the old file into split files, so switching to the new code is painless. All the code was converted to handle the new list of database structures. One part that felt odd was the sss_tools. They should really only operate on the 'local' domain and nothing else. So attaches is also a patch that basically reverts most of the changes and just opens the 'local' database instead. I have not merged them in a single patch because I didn't want to mix format changes with functional changes and because apparently we may want to be a bit more radical and eliminate also the shadow-utils handling at the same time. I have tested the change and the upgrade as well as starting from scratch and all seem to work properly. Simo. -- Simo Sorce * Red Hat, Inc * New York

3 7

[PATCH] Remove shadow-utils support from tools
by Jakub Hrozek 08 Sep '09

08 Sep '09

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 The attached patch applies on top of Simo's two patches. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAkqmZcgACgkQHsardTLnvCWRbgCePRy9eDg32BZIW0DVu4NYJNGk 5qAAn2rm0OXo45s9Q75nAi4cF6hmdmnw =kDDk -----END PGP SIGNATURE-----

3 2

Unpleasant warnings
by Dmitri Pal 08 Sep '09

08 Sep '09

Steve, I ran a build today and saw some unpleasant warnings especially about the uninitialized variables. ../../server/providers/ldap/sdap_async.c: In function 'sdap_get_users_save_done': ../../server/providers/ldap/sdap_async.c:1427: warning: 'timestamp' may be used uninitialized in this function ../../server/db/sysdb.c: In function ‘sysdb_init’: ../../server/db/sysdb.c:597: warning: ‘path’ may be used uninitialized in this function ../../server/tools/sss_useradd.c: In function ‘main’: ../../server/tools/sss_useradd.c:386: warning: assignment discards qualifiers from pointer target type ../../server/tools/sss_useradd.c:424: warning: ‘ret’ is used uninitialized in this function ../../server/tools/sss_usermod.c: In function ‘main’: ../../server/tools/sss_usermod.c:437: warning: assignment discards qualifiers from pointer target type ../../server/tools/sss_groupmod.c: In function ‘main’: ../../server/tools/sss_groupmod.c:373: warning: assignment discards qualifiers from pointer target type ../../server/responder/nss/nsssrv_cmd.c: In function ‘fill_grent’: ../../server/responder/nss/nsssrv_cmd.c:1371: warning: ‘i’ may be used uninitialized in this function -- Thank you, Dmitri Pal Engineering Manager IPA project, Red Hat Inc. ------------------------------- Looking to carve out IT costs? www.redhat.com/carveoutcosts/

4 6

[PATCH] fix libdbus configure check
by Sumit Bose 08 Sep '09

08 Sep '09

Hi, this patch adds some autotols cleanups. bye, Sumit

2 2

[PATCH] initialize sockaddr_in structure
by Sumit Bose 08 Sep '09

08 Sep '09

Hi, valgrind told me that the sockaddr_in structure might be used uninitialized. This patch fixes this and adds some debugging messages I found useful to follow the usage of the plugin. bye, Sumit

2 2

New Try to build SSSD on Karmic both as of 2009.08.04
by Miguel P.C. 08 Sep '09

08 Sep '09

Hi Stephen, hello everyone, I installed the two libraries you said: * docbook-xsl * libxml2-utils And also the ones indicated before: * libtalloc-dev * tdb-dev * libtevent-dev * libldb-dev * cvs * libpopt-dev * libpam-dev * libldap2-dev * libpcre3-dev * krb5-config * libkrb5-dev * libc-ares-dev * libdbus-1-dev * libnss3-dev Hit configure once more: ./configure --prefix=/opt/sssd | tee ../configure.12.log ... and then make: make | tee ../make.1.log I still get the same problem. Seems to be an ldap build dep that doesnt work fine. Do we need 389DS libs to build it? I attach logs. M*

5 14

Design update
by Dmitri Pal 03 Sep '09

03 Sep '09

ELAPI design page has been significantly updated on wiki: https://fedorahosted.org/sssd/wiki/WikiPage/ELAPIInterface -- Thank you, Dmitri Pal Engineering Manager IPA project, Red Hat Inc. ------------------------------- Looking to carve out IT costs? www.redhat.com/carveoutcosts/

1 0

Fix crash in LDAP backend in initgroups() call
by Ralf Haferkamp 03 Sep '09

03 Sep '09

Hi, this is another small patch for a crasher in the LDAP backend. I unsure though if it is the correct fix or if sdap_get_initgr_save_done() should make use of the timestamp argument when calling sdap_save_group_recv() instead of setting it to NULL. AFAICS the problem was introduced with the recent optimization in the enumeration code. At least it's not present in the 0.5.0 release. -- regards, Ralf

3 2

Small fix for rfc2307bis support
by Ralf Haferkamp 03 Sep '09

03 Sep '09

Hi, I am currently giving sssd a try on openSUSE. While I could successfully build it, I ran into a problem with LDAP backend and the initgroups() call when using "ldapSchema = rfc2307bis". sssd created wrong search filters. The attached patch should fix that problem. -- regards, Ralf

3 2

[PATCH] configure cleanups
by Sumit Bose 03 Sep '09

03 Sep '09

Hi, this patch replaces the mailing list address and tries to make version handling easier. I have added a VERSION file at the top level directory and let /configure.ac, /common/configure.ac, /sss_client/configure.ac and /server/configure.ac read the version number from it. To release a new version only this file has to be edited and not all the configure.ac files. A 'make dist' does not change the version number in the Project-Id-Version field of the *.po files. Does someone know if this behaviour is expected? bye, Sumit

3 2

[RFC][PATCH] adding domain-type config option
by Sumit Bose 03 Sep '09

03 Sep '09

Hi, this patch is work in progress, please do not push it to the master repository. I think it makes sense to introduce meta-options which can set more than on option at once. As an example I have implemented a 'domain-type' option which will set a couple of option for an IPA domain at once. To handle more than one meta-option this patch needs a bit more abstraction, but I would like to get some feedback on the general idea. Thanks. bye, Sumit

3 6

[PATCH] Move RPM specfiles into contrib/
by Stephen Gallagher 02 Sep '09

02 Sep '09

Also create a new spec file for RHEL5 -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts/

2 6

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

sssd-devel September 2009