commit add7504fce6baecead6769feedf242c950dcbedd Author: Kalev Lember klember@redhat.com Date: Fri Nov 6 09:08:13 2015 +0100
build: Install snippets/ in 'make install'
https://bugzilla.redhat.com/show_bug.cgi?id=1276987
Makefile | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) --- diff --git a/Makefile b/Makefile index c1f57d1..4cfb865 100644 --- a/Makefile +++ b/Makefile @@ -18,6 +18,8 @@ install: install -m 644 custom/* $(DATADIR)/$(name)/custom mkdir -p -m 755 $(DATADIR)/$(name)/l10n install -m 644 l10n/* $(DATADIR)/$(name)/l10n + mkdir -p -m 755 $(DATADIR)/$(name)/snippets + install -m 644 snippets/* $(DATADIR)/$(name)/snippets
clean: rm -f $(name)-*.tar.gz
On Fri, Nov 06, 2015 at 08:29:28 +0000, Kalev Lember kalev@fedoraproject.org wrote:
--- a/Makefile +++ b/Makefile @@ -18,6 +18,8 @@ install: install -m 644 custom/* $(DATADIR)/$(name)/custom mkdir -p -m 755 $(DATADIR)/$(name)/l10n install -m 644 l10n/* $(DATADIR)/$(name)/l10n
- mkdir -p -m 755 $(DATADIR)/$(name)/snippets
- install -m 644 snippets/* $(DATADIR)/$(name)/snippets
I didn't see a commit where you made sure this ends up in one of the subpackages. For now that should happen. Though I think it would be reasonable to drop the subpackages and keep everything in spin-kickstarts. The total amount of space is small enough that it probably isn't worth the confusion caused by subpackages.
On Fri, Nov 06, 2015 at 14:34:56 -0600, Bruno Wolff III bruno@wolff.to wrote:
On Fri, Nov 06, 2015 at 08:29:28 +0000, Kalev Lember kalev@fedoraproject.org wrote:
--- a/Makefile +++ b/Makefile @@ -18,6 +18,8 @@ install: install -m 644 custom/* $(DATADIR)/$(name)/custom mkdir -p -m 755 $(DATADIR)/$(name)/l10n install -m 644 l10n/* $(DATADIR)/$(name)/l10n
- mkdir -p -m 755 $(DATADIR)/$(name)/snippets
- install -m 644 snippets/* $(DATADIR)/$(name)/snippets
I didn't see a commit where you made sure this ends up in one of the subpackages. For now that should happen. Though I think it would be reasonable to drop the subpackages and keep everything in spin-kickstarts. The total amount of space is small enough that it probably isn't worth the confusion caused by subpackages.
Nevermind. I was stupidly thinking the change message would show up in this thread. But of course that change is to the spin-kickstarts package, not the spin-kickstarts upstream.
-
Bruno Wolff III -
Kalev Lember