backend/satellite_exporter/handlers/non_auth_dumper.py | 4 +++-
backend/satellite_exporter/satexport.py | 12 ++++++++----
backend/spacewalk-backend.spec | 6 +++++-
rel-eng/packages/spacewalk-backend | 2 +-
4 files changed, 17 insertions(+), 7 deletions(-)
New commits:
commit 4760d6d56af9fba06f0db2f6472aec95dda65393
Author: Michael Mraka <michael.mraka(a)redhat.com>
Date: Mon Jul 30 17:06:46 2012 +0200
Automatic commit of package [spacewalk-backend] release [1.8.54-1].
diff --git a/backend/spacewalk-backend.spec b/backend/spacewalk-backend.spec
index 4d79f0c..86a955a 100644
--- a/backend/spacewalk-backend.spec
+++ b/backend/spacewalk-backend.spec
@@ -12,7 +12,7 @@ Name: spacewalk-backend
Summary: Common programs needed to be installed on the Spacewalk servers/proxies
Group: Applications/Internet
License: GPLv2
-Version: 1.8.53
+Version: 1.8.54
Release: 1%{?dist}
URL:
https://fedorahosted.org/spacewalk
Source0:
https://fedorahosted.org/releases/s/p/spacewalk/%{name}-%{version}.tar.gz
@@ -647,6 +647,9 @@ rm -f %{rhnconf}/rhnSecret.py*
# $Id$
%changelog
+* Mon Jul 30 2012 Michael Mraka <michael.mraka(a)redhat.com> 1.8.54-1
+- satellite_exporter is now pylint-able
+
* Mon Jul 30 2012 Michael Mraka <michael.mraka(a)redhat.com> 1.8.53-1
- update_contact_info is not called from client for a long time
- removed unaccessible code
diff --git a/rel-eng/packages/spacewalk-backend b/rel-eng/packages/spacewalk-backend
index d9f280f..9eade68 100644
--- a/rel-eng/packages/spacewalk-backend
+++ b/rel-eng/packages/spacewalk-backend
@@ -1 +1 @@
-1.8.53-1 backend/
+1.8.54-1 backend/
commit 7c6e03c8616e21f674119ec218ca072a58635e56
Author: Michael Mraka <michael.mraka(a)redhat.com>
Date: Mon Jul 30 16:47:26 2012 +0200
locally disabled Too many public methods
diff --git a/backend/satellite_exporter/handlers/non_auth_dumper.py
b/backend/satellite_exporter/handlers/non_auth_dumper.py
index b4c277e..68e3e05 100644
--- a/backend/satellite_exporter/handlers/non_auth_dumper.py
+++ b/backend/satellite_exporter/handlers/non_auth_dumper.py
@@ -44,7 +44,7 @@ class MissingPackageError(Exception):
pass
class NonAuthenticatedDumper(rhnHandler, dumper.XML_Dumper):
- # pylint: disable=E1101,W0102,W0613,R0902
+ # pylint: disable=E1101,W0102,W0613,R0902,R0904
def __init__(self, req):
rhnHandler.__init__(self)
dumper.XML_Dumper.__init__(self)
commit 90da785c14e3ac5aa8e5f1cacb3084f7d334fb8f
Author: Michael Mraka <michael.mraka(a)redhat.com>
Date: Mon Jul 30 16:47:07 2012 +0200
locally disabled Too many instance attributes
diff --git a/backend/satellite_exporter/handlers/non_auth_dumper.py
b/backend/satellite_exporter/handlers/non_auth_dumper.py
index ec0a9c9..b4c277e 100644
--- a/backend/satellite_exporter/handlers/non_auth_dumper.py
+++ b/backend/satellite_exporter/handlers/non_auth_dumper.py
@@ -44,7 +44,7 @@ class MissingPackageError(Exception):
pass
class NonAuthenticatedDumper(rhnHandler, dumper.XML_Dumper):
- # pylint: disable=E1101,W0102,W0613
+ # pylint: disable=E1101,W0102,W0613,R0902
def __init__(self, req):
rhnHandler.__init__(self)
dumper.XML_Dumper.__init__(self)
commit 5e15b3b642757316477770c118ba0a35c0e5803c
Author: Michael Mraka <michael.mraka(a)redhat.com>
Date: Mon Jul 30 16:44:51 2012 +0200
satellite_exporter is now pylint-able
diff --git a/backend/spacewalk-backend.spec b/backend/spacewalk-backend.spec
index 41d0466..4d79f0c 100644
--- a/backend/spacewalk-backend.spec
+++ b/backend/spacewalk-backend.spec
@@ -299,6 +299,7 @@ make -f Makefile.backend PYTHONPATH=$RPM_BUILD_ROOT%{python_sitelib}
test || :
# check coding style
export PYTHONPATH=$RPM_BUILD_ROOT%{python_sitelib}:/usr/lib/rhn
spacewalk-pylint $RPM_BUILD_ROOT%{pythonrhnroot}/common \
+ $RPM_BUILD_ROOT%{pythonrhnroot}/satellite_exporter \
$RPM_BUILD_ROOT%{pythonrhnroot}/wsgi
%endif
commit d202526f214b730f38135927b4f5c0a80a9e5ea1
Author: Michael Mraka <michael.mraka(a)redhat.com>
Date: Mon Jul 30 16:37:23 2012 +0200
fixed NonAuthenticatedDumper._send_stream: Attribute 'compress_level' defined
outside __init__
diff --git a/backend/satellite_exporter/handlers/non_auth_dumper.py
b/backend/satellite_exporter/handlers/non_auth_dumper.py
index 6e9e96f..ec0a9c9 100644
--- a/backend/satellite_exporter/handlers/non_auth_dumper.py
+++ b/backend/satellite_exporter/handlers/non_auth_dumper.py
@@ -51,6 +51,7 @@ class NonAuthenticatedDumper(rhnHandler, dumper.XML_Dumper):
self.headers_out = UserDictCase()
self._raw_stream = req
self._raw_stream.content_type = 'application/octet-stream'
+ self.compress_level = 0
# State machine
self._headers_sent = 0
self._is_closed = 0
commit 1f9fd949baa154911d214e1eccbe86808f81f7fa
Author: Michael Mraka <michael.mraka(a)redhat.com>
Date: Mon Jul 30 16:36:08 2012 +0200
locally disabled Unused argument
NonAuthenticatedDumper.channel_families: Unused argument 'channel_labels'
NonAuthenticatedDumper.channels: Unused argument 'flags'
diff --git a/backend/satellite_exporter/handlers/non_auth_dumper.py
b/backend/satellite_exporter/handlers/non_auth_dumper.py
index 61ec00b..6e9e96f 100644
--- a/backend/satellite_exporter/handlers/non_auth_dumper.py
+++ b/backend/satellite_exporter/handlers/non_auth_dumper.py
@@ -44,7 +44,7 @@ class MissingPackageError(Exception):
pass
class NonAuthenticatedDumper(rhnHandler, dumper.XML_Dumper):
- # pylint: disable=E1101,W0102
+ # pylint: disable=E1101,W0102,W0613
def __init__(self, req):
rhnHandler.__init__(self)
dumper.XML_Dumper.__init__(self)
commit 5cc54e3a73500f8803780ef07b83ef118e8f6fe7
Author: Michael Mraka <michael.mraka(a)redhat.com>
Date: Mon Jul 30 16:20:05 2012 +0200
fixed NonAuthenticatedDumper.close: Unnecessary pass statement
diff --git a/backend/satellite_exporter/handlers/non_auth_dumper.py
b/backend/satellite_exporter/handlers/non_auth_dumper.py
index c15c52a..61ec00b 100644
--- a/backend/satellite_exporter/handlers/non_auth_dumper.py
+++ b/backend/satellite_exporter/handlers/non_auth_dumper.py
@@ -151,7 +151,7 @@ class NonAuthenticatedDumper(rhnHandler, dumper.XML_Dumper):
except IOError, e:
# Remote end has closed connection already
log_error("Error closing the stream", str(e))
- pass
+
self._compressed_stream = None
self._is_closed = 1
log_debug(3, "Closed")
commit 22526498ab7b9b5e76fd6a3a89b2a582d41354ec
Author: Michael Mraka <michael.mraka(a)redhat.com>
Date: Mon Jul 30 16:18:39 2012 +0200
locally disabled Dangerous default value
NonAuthenticatedDumper.set_channel_family_query: Dangerous default value [] as
argument
NonAuthenticatedDumper.channel_families: Dangerous default value [] as argument
NonAuthenticatedDumper.channels: Dangerous default value {} as argument
NonAuthenticatedDumper.packages: Dangerous default value [] as argument
NonAuthenticatedDumper.packages_short: Dangerous default value [] as argument
NonAuthenticatedDumper.source_packages: Dangerous default value [] as argument
NonAuthenticatedDumper.errata: Dangerous default value [] as argument
NonAuthenticatedDumper.kickstartable_trees: Dangerous default value [] as argument
diff --git a/backend/satellite_exporter/handlers/non_auth_dumper.py
b/backend/satellite_exporter/handlers/non_auth_dumper.py
index 6afaff9..c15c52a 100644
--- a/backend/satellite_exporter/handlers/non_auth_dumper.py
+++ b/backend/satellite_exporter/handlers/non_auth_dumper.py
@@ -44,7 +44,7 @@ class MissingPackageError(Exception):
pass
class NonAuthenticatedDumper(rhnHandler, dumper.XML_Dumper):
- # pylint: disable=E1101
+ # pylint: disable=E1101,W0102
def __init__(self, req):
rhnHandler.__init__(self)
dumper.XML_Dumper.__init__(self)
commit 767c68690ebce60e0358195132da40a7220c69a9
Author: Michael Mraka <michael.mraka(a)redhat.com>
Date: Mon Jul 30 16:15:48 2012 +0200
locally disabled Instance of 'NonAuthenticatedDumper' has no 'xxx'
member
NonAuthenticatedDumper._get_channel_data: Instance of 'ChannelsDumper' has no
'dump' member
NonAuthenticatedDumper.dump_channel_families: Instance of
'NonAuthenticatedDumper' has no 'get_channel_families_statement' member
NonAuthenticatedDumper.dump_channel_families: Instance of
'NonAuthenticatedDumper' has no '_get_xml_writer' member
NonAuthenticatedDumper.dump_channels: Instance of 'NonAuthenticatedDumper' has
no '_validate_channels' member
NonAuthenticatedDumper.dump_channels: Instance of 'NonAuthenticatedDumper' has
no '_get_xml_writer' member
NonAuthenticatedDumper.dump_product_names: Instance of
'NonAuthenticatedDumper' has no '_get_xml_writer' member
NonAuthenticatedDumper.arches: Instance of 'NonAuthenticatedDumper' has no
'dump_arches' member
NonAuthenticatedDumper.arches_extra: Instance of 'NonAuthenticatedDumper' has
no 'dump_server_group_type_server_arches' member
NonAuthenticatedDumper.blacklist_obsoletes: Instance of
'NonAuthenticatedDumper' has no 'dump_blacklist_obsoletes' member
NonAuthenticatedDumper.packages_short: Instance of 'NonAuthenticatedDumper'
has no 'dump_packages_short' member
NonAuthenticatedDumper.source_packages: Instance of 'NonAuthenticatedDumper'
has no 'dump_source_packages' member
ChannelsDumper.dump_subelement: Instance of 'ChannelsDumper' has no
'_writer' member
diff --git a/backend/satellite_exporter/handlers/non_auth_dumper.py
b/backend/satellite_exporter/handlers/non_auth_dumper.py
index 0205c74..6afaff9 100644
--- a/backend/satellite_exporter/handlers/non_auth_dumper.py
+++ b/backend/satellite_exporter/handlers/non_auth_dumper.py
@@ -44,6 +44,7 @@ class MissingPackageError(Exception):
pass
class NonAuthenticatedDumper(rhnHandler, dumper.XML_Dumper):
+ # pylint: disable=E1101
def __init__(self, req):
rhnHandler.__init__(self)
dumper.XML_Dumper.__init__(self)
commit 04637cfe8d0283263016443b970711c63fdf9798
Author: Michael Mraka <michael.mraka(a)redhat.com>
Date: Mon Jul 30 16:14:29 2012 +0200
locally disabled BaseApacheServer.headerParserHandler: No exception type(s) specified
diff --git a/backend/satellite_exporter/satexport.py
b/backend/satellite_exporter/satexport.py
index b1c24ce..57f8468 100644
--- a/backend/satellite_exporter/satexport.py
+++ b/backend/satellite_exporter/satexport.py
@@ -54,6 +54,7 @@ class BaseApacheServer:
try:
rhnSQL.closeDB()
except:
+ # pylint: disable=W0702
pass
# Fetch global message being sent to clients if applicable.
commit c7150ff8606c686ae1a807e3b62e3e27df422fff
Author: Michael Mraka <michael.mraka(a)redhat.com>
Date: Mon Jul 30 16:12:30 2012 +0200
fixed ApacheServer._validate_version: Method could be a function
diff --git a/backend/satellite_exporter/satexport.py
b/backend/satellite_exporter/satexport.py
index 4474459..b1c24ce 100644
--- a/backend/satellite_exporter/satexport.py
+++ b/backend/satellite_exporter/satexport.py
@@ -198,7 +198,8 @@ class ApacheServer(BaseApacheServer):
(module_name, function_name))
return f
- def _validate_version(self, req):
+ @staticmethod
+ def _validate_version(req):
server_version = constants.PROTOCOL_VERSION
vstr = 'X-RHN-Satellite-XML-Dump-Version'
if not req.headers_in.has_key(vstr):
commit e019928b7aaa08490dcbd8d52de4412559efd26a
Author: Michael Mraka <michael.mraka(a)redhat.com>
Date: Mon Jul 30 16:11:08 2012 +0200
locally disabled Method could be a function
BaseApacheServer._headerParserHandler: Method could be a function
BaseApacheServer._handler: Method could be a function
BaseApacheServer._cleanupHandler: Method could be a function
BaseApacheServer._send_xmlrpc: Method could be a function
ApacheServer._validate_version: Method could be a function
diff --git a/backend/satellite_exporter/satexport.py
b/backend/satellite_exporter/satexport.py
index 276bf71..4474459 100644
--- a/backend/satellite_exporter/satexport.py
+++ b/backend/satellite_exporter/satexport.py
@@ -92,6 +92,7 @@ class BaseApacheServer:
self.server_instance = {}
# Virtual functions
+ # pylint: disable=R0201
def _headerParserHandler(self, _req):
return apache.OK
commit 05b49a9c93c81804494049613da60d5c0266821a
Author: Michael Mraka <michael.mraka(a)redhat.com>
Date: Mon Jul 30 16:04:19 2012 +0200
locally disabled Attribute defined outside __init__
BaseApacheServer._cleanup: Attribute 'server_instance' defined outside
__init__
BaseApacheServer._cleanup: Attribute 'server_classes' defined outside
__init__
BaseApacheServer._cleanup: Attribute 'server' defined outside __init__
diff --git a/backend/satellite_exporter/satexport.py
b/backend/satellite_exporter/satexport.py
index a91b9b3..276bf71 100644
--- a/backend/satellite_exporter/satexport.py
+++ b/backend/satellite_exporter/satexport.py
@@ -86,6 +86,7 @@ class BaseApacheServer:
return retval
def _cleanup(self):
+ # pylint: disable=W0201
self.server = None
self.server_classes = None
self.server_instance = {}
commit b393b3b879da11da7b8c1bff60afea5d461adfb3
Author: Michael Mraka <michael.mraka(a)redhat.com>
Date: Mon Jul 30 16:01:00 2012 +0200
fixed BaseApacheServer._headerParserHandler: Unused argument 'req'
BaseApacheServer._handler: Unused argument 'req'
BaseApacheServer._cleanupHandler: Unused argument 'req'
diff --git a/backend/satellite_exporter/satexport.py
b/backend/satellite_exporter/satexport.py
index 0f7faf1..a91b9b3 100644
--- a/backend/satellite_exporter/satexport.py
+++ b/backend/satellite_exporter/satexport.py
@@ -91,13 +91,13 @@ class BaseApacheServer:
self.server_instance = {}
# Virtual functions
- def _headerParserHandler(self, req):
+ def _headerParserHandler(self, _req):
return apache.OK
- def _handler(self, req):
+ def _handler(self, _req):
return apache.OK
- def _cleanupHandler(self, req):
+ def _cleanupHandler(self, _req):
return apache.OK
def _wrapper(self, req, function):