backend/common/rhn_deb.py | 9 +++++++++ backend/common/rhn_mpm.py | 5 ++++- backend/common/rhn_rpm.py | 9 +++++++++ rel-eng/packages/spacewalk-pylint | 2 +- spacewalk/pylint/spacewalk-pylint.rc | 3 +-- spacewalk/pylint/spacewalk-pylint.spec | 5 ++++- 6 files changed, 28 insertions(+), 5 deletions(-)
New commits: commit 21a3fe120e5c6774faf7d6e6899054ff48315fcd Author: Michael Mraka michael.mraka@redhat.com Date: Mon Jan 28 16:07:30 2013 +0100
Automatic commit of package [spacewalk-pylint] release [0.11-1].
diff --git a/rel-eng/packages/spacewalk-pylint b/rel-eng/packages/spacewalk-pylint index 8d79759..253e245 100644 --- a/rel-eng/packages/spacewalk-pylint +++ b/rel-eng/packages/spacewalk-pylint @@ -1 +1 @@ -0.10-1 spacewalk/pylint/ +0.11-1 spacewalk/pylint/ diff --git a/spacewalk/pylint/spacewalk-pylint.spec b/spacewalk/pylint/spacewalk-pylint.spec index 99e6721..0ff4ff0 100644 --- a/spacewalk/pylint/spacewalk-pylint.spec +++ b/spacewalk/pylint/spacewalk-pylint.spec @@ -1,5 +1,5 @@ Name: spacewalk-pylint -Version: 0.10 +Version: 0.11 Release: 1%{?dist} Summary: Pylint configuration for spacewalk python packages
@@ -49,6 +49,9 @@ rm -rf %{buildroot} %doc LICENSE
%changelog +* Mon Jan 28 2013 Michael Mraka michael.mraka@redhat.com 0.11-1 +- Revert "ignore Container implementation related warnings" + * Fri Jan 25 2013 Michael Mraka michael.mraka@redhat.com 0.10-1 - ignore Container implementation related warnings
commit dcc603f54974b116431d52f22e92b770edd97082 Author: Michael Mraka michael.mraka@redhat.com Date: Mon Jan 28 16:04:36 2013 +0100
Revert "ignore Container implementation related warnings"
This reverts commit be79446123458962242fa8fa51e62fdce9d96365. R0924 check is not implemented in pylint on RHEL6 which causes Traceback (most recent call last): File "/usr/bin/pylint", line 4, in <module> lint.Run(sys.argv[1:]) File "/usr/lib/python2.6/site-packages/pylint/lint.py", line 832, in __init__ linter.load_config_file() File "/usr/lib/python2.6/site-packages/logilab/common/configuration.py", line 655, in load_config_file provider.set_option(option, value, optdict=optdict) File "/usr/lib/python2.6/site-packages/pylint/lint.py", line 297, in set_option meth(_id) File "/usr/lib/python2.6/site-packages/pylint/utils.py", line 170, in disable msg = self.check_message_id(msgid) File "/usr/lib/python2.6/site-packages/pylint/utils.py", line 227, in check_message_id raise UnknownMessage('No such message id %s' % msgid) pylint.utils.UnknownMessage: No such message id R0924
diff --git a/spacewalk/pylint/spacewalk-pylint.rc b/spacewalk/pylint/spacewalk-pylint.rc index 7671412..990c8e6 100644 --- a/spacewalk/pylint/spacewalk-pylint.rc +++ b/spacewalk/pylint/spacewalk-pylint.rc @@ -12,7 +12,7 @@ persistent=no [MESSAGES CONTROL]
# Disable the message(s) with the given id(s). -disable=I0011,C0302,C0111,R0801,R0902,R0904,R0912,R0913,R0914,R0915,R0924,W0142,W0403,W0603 +disable=I0011,C0302,C0111,R0801,R0902,R0904,R0912,R0913,R0914,R0915,W0142,W0403,W0603
# list of disabled messages: #I0011: 62: Locally disabling R0201 @@ -23,7 +23,6 @@ disable=I0011,C0302,C0111,R0801,R0902,R0904,R0912,R0913,R0914,R0915,R0924,W0142, #R0912:171:set_slots_from_cert: Too many branches (59/20) #R0913:101:GETServer.__init__: Too many arguments (11/10) #R0914:171:set_slots_from_cert: Too many local variables (38/20) -#R0924: 30,0:deb_Header: Badly implemented Container, implements __getitem__ but not __delitem__, __len__, __setitem__ #R0915:171:set_slots_from_cert: Too many statements (169/50) #W0142:228:MPM_Package.write: Used * or ** magic #W0403: 28: Relative import 'rhnLog', should be 'backend.common.rhnLog'
commit fbff981103d1545ac53b11e943c79516acf8266c Author: Michael Mraka michael.mraka@redhat.com Date: Mon Jan 28 15:58:06 2013 +0100
fixed container implementation
fixing R0924: 30,0:deb_Header: Badly implemented Container, implements __getitem__ but not __delitem__, __len__, __setitem__
diff --git a/backend/common/rhn_deb.py b/backend/common/rhn_deb.py index a3b9ef0..4dd78d5 100644 --- a/backend/common/rhn_deb.py +++ b/backend/common/rhn_deb.py @@ -86,9 +86,18 @@ class deb_Header: def __getitem__(self, name): return self.hdr.get(str(name))
+ def __setitem__(self, name, item): + self.hdr[name] = item + + def __delitem__(self, name): + del self.hdr[name] + def __getattr__(self, name): return getattr(self.hdr, name)
+ def __len__(self): + return len(self.hdr) + class DEB_Package(A_Package): def __init__(self, input_stream = None): A_Package.__init__(self, input_stream)
commit 6057a5e61f494d59e33a26e1f2e1b893cfa17b3d Author: Michael Mraka michael.mraka@redhat.com Date: Mon Jan 28 15:58:06 2013 +0100
fixed container implementation
fixing R0924: 65,0:RPM_Header: Badly implemented Container, implements __getitem__ but not __delitem__, __len__, __setitem__
diff --git a/backend/common/rhn_rpm.py b/backend/common/rhn_rpm.py index ee674b9..8ef1545 100644 --- a/backend/common/rhn_rpm.py +++ b/backend/common/rhn_rpm.py @@ -74,9 +74,18 @@ class RPM_Header: def __getitem__(self, name): return self.hdr[name]
+ def __setitem__(self, name, item): + self.hdr[name] = item + + def __delitem__(self, name): + del self.hdr[name] + def __getattr__(self, name): return getattr(self.hdr, name)
+ def __len__(self): + return len(self.hdr) + def __nonzero__(self): if self.hdr: return True
commit d8c76dca9a5b456d7d98cdbe2e20630b1da3132d Author: Michael Mraka michael.mraka@redhat.com Date: Mon Jan 28 15:58:06 2013 +0100
fixed container implementation
fixing R0924: 98,0:MPM_Header: Badly implemented Container, implements __delitem__, __getitem__, __setitem__ but not __len__
diff --git a/backend/common/rhn_mpm.py b/backend/common/rhn_mpm.py index 324e021..f663fab 100644 --- a/backend/common/rhn_mpm.py +++ b/backend/common/rhn_mpm.py @@ -115,6 +115,9 @@ class MPM_Header: def __getattr__(self, name): return getattr(self.hdr, name)
+ def __len__(self): + return len(self.hdr) + @staticmethod def is_signed(): return 0
commit c73ffdd68cb6d48330f88eba0745ba2a8434d1a5 Author: Michael Mraka michael.mraka@redhat.com Date: Fri Jan 25 13:07:23 2013 +0100
fixing order of disabled messages
diff --git a/backend/common/rhn_mpm.py b/backend/common/rhn_mpm.py index 8072d67..324e021 100644 --- a/backend/common/rhn_mpm.py +++ b/backend/common/rhn_mpm.py @@ -221,7 +221,7 @@ class MPM_Package(A_Package): self._encode_header(output_stream) self._encode_payload(output_stream)
- # pylint: disable=W1401,E0012 + # pylint: disable=E0012,W1401 # now we know header and payload size so rewind back and write lead lead_arr = (self._magic, 1, "\0" * 3, self.header_flags, self.payload_flags, self.header_size, self.payload_size, '\0' * 92)
spacewalk-commits@lists.fedorahosted.org