backend/satellite_tools/disk_dumper/iss_runcommand.py | 2 +-
backend/spacewalk/common/fileutils.py | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
New commits:
commit c7b3012042cdf9619ac874a36ad3df2ece93a408
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Mon Jan 25 16:19:29 2010 +0100
execute commands through shell
Currently these commands fails. If shell=False (which is default on Unix) you have to
pass
sequence (which couse me currently some other bugs) or if you pass as args string, you
have to execute
it through shell
diff --git a/backend/satellite_tools/disk_dumper/iss_runcommand.py
b/backend/satellite_tools/disk_dumper/iss_runcommand.py
index 0fe85de..4becf1d 100644
--- a/backend/satellite_tools/disk_dumper/iss_runcommand.py
+++ b/backend/satellite_tools/disk_dumper/iss_runcommand.py
@@ -36,7 +36,7 @@ def make_fd_nonblocking(file_desc):
def run_command(command):
command_process = subprocess.Popen(command, stdin=subprocess.PIPE,
stdout=subprocess.PIPE, stderr=subprocess.PIPE,
- close_fds=True)
+ close_fds=True, shell=True)
outstring = StringIO.StringIO()
errstring = StringIO.StringIO()
diff --git a/backend/spacewalk/common/fileutils.py
b/backend/spacewalk/common/fileutils.py
index 4b1ad2c..eeadfab 100644
--- a/backend/spacewalk/common/fileutils.py
+++ b/backend/spacewalk/common/fileutils.py
@@ -209,7 +209,8 @@ def rhn_popen(cmd, progressCallback=None, bufferSize=16384,
outputLog=None):
if type(cmd) in (types.ListType, types.TupleType):
cmd = map(str, cmd)
c = subprocess.Popen(cmd, bufsize=0, stdin=subprocess.PIPE,
- stdout=subprocess.PIPE, stderr=subprocess.PIPE, close_fds=True)
+ stdout=subprocess.PIPE, stderr=subprocess.PIPE,
+ close_fds=True, shell=True)
# We don't write to the child process
c.stdin.close()
commit 347c2a750ee6d979e6777bcadfa16f66c5f9ebd4
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Mon Jan 25 14:34:43 2010 +0100
cleanup - this comments do not have sense since commit 7ec5fa4c
diff --git a/backend/spacewalk/common/fileutils.py
b/backend/spacewalk/common/fileutils.py
index 66b96da..4b1ad2c 100644
--- a/backend/spacewalk/common/fileutils.py
+++ b/backend/spacewalk/common/fileutils.py
@@ -206,7 +206,6 @@ def rhn_popen(cmd, progressCallback=None, bufferSize=16384,
outputLog=None):
subprocess._cleanup()
- # If you want unbuffered, set bufsize to 0
if type(cmd) in (types.ListType, types.TupleType):
cmd = map(str, cmd)
c = subprocess.Popen(cmd, bufsize=0, stdin=subprocess.PIPE,
Show replies by thread