java/code/src/com/redhat/rhn/common/validator/HostPortValidator.java | 2 java/code/src/com/redhat/rhn/common/validator/test/HostPortValidatorTest.java | 24 ++++++---- 2 files changed, 17 insertions(+), 9 deletions(-)
New commits: commit e59a26c7ac2dba4bfb97ec819f234fea5d28a26e Author: Jan Pazdziora jpazdziora@redhat.com Date: Thu Sep 20 10:19:23 2012 +0200
Checkstyle fix.
Addressing Starting audit... /builddir/build/BUILD/spacewalk-java-1.8.149/./code/src/com/redhat/rhn/common/validator/HostPortValidator.java:54:35: Expected @param tag for 'hostPort'. Audit done. Starting audit... /builddir/build/BUILD/spacewalk-java-git-1.8187a01/./code/src/com/redhat/rhn/common/validator/test/HostPortValidatorTest.java:39: Line is longer than 92 characters. /builddir/build/BUILD/spacewalk-java-git-1.8187a01/./code/src/com/redhat/rhn/common/validator/test/HostPortValidatorTest.java:40: Line is longer than 92 characters. /builddir/build/BUILD/spacewalk-java-git-1.8187a01/./code/src/com/redhat/rhn/common/validator/test/HostPortValidatorTest.java:41: Line is longer than 92 characters. /builddir/build/BUILD/spacewalk-java-git-1.8187a01/./code/src/com/redhat/rhn/common/validator/test/HostPortValidatorTest.java:46: Line is longer than 92 characters. /builddir/build/BUILD/spacewalk-java-git-1.8187a01/./code/src/com/redhat/rhn/common/validator/test/HostPortValidatorTest.java:47: Line is longer than 92 characters. /builddir/build/BUILD/spacewalk-java-git-1.8187a01/./code/src/com/redhat/rhn/common/validator/test/HostPortValidatorTest.java:48: Line is longer than 92 characters. /builddir/build/BUILD/spacewalk-java-git-1.8187a01/./code/src/com/redhat/rhn/common/validator/test/HostPortValidatorTest.java:49: Line is longer than 92 characters. /builddir/build/BUILD/spacewalk-java-git-1.8187a01/./code/src/com/redhat/rhn/common/validator/test/HostPortValidatorTest.java:61: Line is longer than 92 characters. Audit done.
diff --git a/java/code/src/com/redhat/rhn/common/validator/HostPortValidator.java b/java/code/src/com/redhat/rhn/common/validator/HostPortValidator.java index cff8ad7..0210d5b 100644 --- a/java/code/src/com/redhat/rhn/common/validator/HostPortValidator.java +++ b/java/code/src/com/redhat/rhn/common/validator/HostPortValidator.java @@ -48,7 +48,7 @@ public class HostPortValidator {
/** * Return true if the given string is a valid host[:port] representation. - * @param hostPort + * @param hostPort the string with host[:port] * @return true if hostPort represents a valid host and port, else false. */ public boolean isValid(String hostPort) { diff --git a/java/code/src/com/redhat/rhn/common/validator/test/HostPortValidatorTest.java b/java/code/src/com/redhat/rhn/common/validator/test/HostPortValidatorTest.java index e96bd91..b934ec9 100644 --- a/java/code/src/com/redhat/rhn/common/validator/test/HostPortValidatorTest.java +++ b/java/code/src/com/redhat/rhn/common/validator/test/HostPortValidatorTest.java @@ -36,17 +36,24 @@ public class HostPortValidatorTest extends TestCase { }
public void testIPv6() { - assertTrue(HostPortValidator.getInstance().isValid("2001:0db8:85a3:08d3:1319:8a2e:0370:7344")); - assertTrue(HostPortValidator.getInstance().isValid("[2001:0db8:85a3:08d3:1319:8a2e:0370:7344]")); - assertTrue(HostPortValidator.getInstance().isValid("[2001:0db8:85a3:08d3:1319:8a2e:0370:7344]:8888")); + assertTrue(HostPortValidator.getInstance().isValid( + "2001:0db8:85a3:08d3:1319:8a2e:0370:7344")); + assertTrue(HostPortValidator.getInstance().isValid( + "[2001:0db8:85a3:08d3:1319:8a2e:0370:7344]")); + assertTrue(HostPortValidator.getInstance().isValid( + "[2001:0db8:85a3:08d3:1319:8a2e:0370:7344]:8888")); assertTrue(HostPortValidator.getInstance().isValid("[2607:f0d0:1002:51::4]:8888")); assertTrue(HostPortValidator.getInstance().isValid("[::1]")); assertTrue(HostPortValidator.getInstance().isValid("[::1]:8888"));
- assertFalse(HostPortValidator.getInstance().isValid("2001:0db8:85a3:08d3:1319:8a2e:0370:7344:8888")); - assertFalse(HostPortValidator.getInstance().isValid("[2001:0db8:85a3:08d3:1319:8a2e:0370:7344]]:8888")); - assertFalse(HostPortValidator.getInstance().isValid("[2001:0db8:85a3:08d3:1319:8a2e:0370:7344:8888")); - assertFalse(HostPortValidator.getInstance().isValid("2001:0db8:85a3:08d3:1319:8a2e:0370:7344]:8888")); + assertFalse(HostPortValidator.getInstance().isValid( + "2001:0db8:85a3:08d3:1319:8a2e:0370:7344:8888")); + assertFalse(HostPortValidator.getInstance().isValid( + "[2001:0db8:85a3:08d3:1319:8a2e:0370:7344]]:8888")); + assertFalse(HostPortValidator.getInstance().isValid( + "[2001:0db8:85a3:08d3:1319:8a2e:0370:7344:8888")); + assertFalse(HostPortValidator.getInstance().isValid( + "2001:0db8:85a3:08d3:1319:8a2e:0370:7344]:8888")); assertFalse(HostPortValidator.getInstance().isValid("[::1]:")); assertFalse(HostPortValidator.getInstance().isValid("[]")); } @@ -58,6 +65,7 @@ public class HostPortValidatorTest extends TestCase { assertTrue(HostPortValidator.getInstance().isValid("proxy.example.com:8888"));
assertFalse(HostPortValidator.getInstance().isValid("http://proxy.example.com")); - assertFalse(HostPortValidator.getInstance().isValid("http://proxy.example.com:8888")); + assertFalse(HostPortValidator.getInstance().isValid( + "http://proxy.example.com:8888")); } }
spacewalk-commits@lists.fedorahosted.org